Skip to content

Backport ANCM environment variable additions #20006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Conversation

BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Mar 19, 2020

Description

In order to run apps locally in VS with a nice. clean experience, there are times when VS will modify a users web.config, which is not a nice experience. In order to avoid modifying user code we have added some features to ANCM to allow VS to use environment variables to override behavior instead of modifying users' files.

#19451
#19450

Customer Impact

This issue has been reported by customers, it impacts them because it modifies their files which is very undesirable behavior.
See this issue https://github.com/aspnet/websdk/issues/564 with over 20 upvotes.

Regression?

No.

Risk

Low, we look for the new environment variables but fallback to old behavior if they aren't present.

@BrennanConroy BrennanConroy added this to the 3.1.x milestone Mar 19, 2020
@BrennanConroy BrennanConroy changed the base branch from master to release/3.1 March 19, 2020 17:14
@BrennanConroy BrennanConroy added the Servicing-consider Shiproom approval is required for the issue label Mar 19, 2020
@ghost
Copy link

ghost commented Mar 19, 2020

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

@BrennanConroy BrennanConroy marked this pull request as ready for review March 19, 2020 21:11
@analogrelay
Copy link
Contributor

I won’t be able to be at Tactics to rep this (childcare strikes again!), I can send an email with more details and justification if necessary. This is a request from VS Web Tools. Currently VS modifies the web.config to inject their launch configuration data but this breaks some customer scenarios (and in general, modifying a file that customers maintain causes weird conflicts).

In 5.0 we’re introducing new environment variables that VS can set when launching the app to override the web.config values it normally modifies. Due to high customer feedback (both in our repo and VS feedback) we want to back port this to 3.1. 2.1 is not affected since this only applies to IIS in-proc hosting (added in 2.2).

@analogrelay
Copy link
Contributor

Marking approved as per email discussion.

@analogrelay analogrelay added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Mar 27, 2020
@BrennanConroy
Copy link
Member Author

Want to click the merge button too :D

@vijayrkn vijayrkn modified the milestones: 3.1.x, 3.1.4 Mar 27, 2020
@analogrelay
Copy link
Contributor

Yep, just wanted to check we were open for merging. And we are! Yay!

@analogrelay analogrelay merged commit 654cf06 into release/3.1 Mar 27, 2020
@analogrelay analogrelay deleted the brecon/bpANCM branch March 27, 2020 17:56
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants