[master] Update dependencies from dotnet/arcade dotnet/aspnetcore-tooling

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/aspnetcore-tooling

• Subscription: b4589d4d-ab29-4a8a-d45b-08d76e1d3434
• Build: 20200325.2
• Date Produced: 3/25/2020 6:35 PM
• Commit: 17e40bd496cbbb456b34710adcbe668da1075f74
• Branch: refs/heads/master
• Updates:
  • Microsoft.AspNetCore.Mvc.Razor.Extensions -> 5.0.0-preview.3.20175.2
  • Microsoft.AspNetCore.Razor.Language -> 5.0.0-preview.3.20175.2
  • Microsoft.CodeAnalysis.Razor -> 5.0.0-preview.3.20175.2
  • Microsoft.NET.Sdk.Razor -> 5.0.0-preview.3.20175.2

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

• Microsoft.AspNetCore.Analyzer.Testing -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Caching.Abstractions -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Caching.Memory -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Caching.SqlServer -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Caching.StackExchangeRedis -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Configuration.Abstractions -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Configuration.Binder -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Configuration.CommandLine -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Configuration.EnvironmentVariables -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Configuration.FileExtensions -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Configuration.Ini -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Configuration.Json -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Configuration.UserSecrets -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Configuration.Xml -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Configuration -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.DependencyInjection.Abstractions -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.DependencyInjection -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.DiagnosticAdapter -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.FileProviders.Abstractions -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.FileProviders.Composite -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.FileProviders.Physical -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.FileSystemGlobbing -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Hosting.Abstractions -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Hosting -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Http -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Logging.Abstractions -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Logging.AzureAppServices -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Logging.Configuration -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Logging.Console -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Logging.Debug -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Logging.EventSource -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Logging.EventLog -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Logging.TraceSource -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Logging.Testing -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Options.ConfigurationExtensions -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Options.DataAnnotations -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Options -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Extensions.Primitives -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Internal.Extensions.Refs -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Win32.Registry -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• Microsoft.NETCore.App.Runtime.win-x64 -> 5.0.0-preview.3.20174.7 (parent: Microsoft.Extensions.Logging)
• Microsoft.Extensions.Logging -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Win32.SystemEvents -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.ComponentModel.Annotations -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Diagnostics.EventLog -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Drawing.Common -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.IO.Pipelines -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Net.Http.WinHttpHandler -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Net.WebSockets.WebSocketProtocol -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Reflection.Metadata -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Runtime.CompilerServices.Unsafe -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Security.Cryptography.Cng -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Security.Cryptography.Pkcs -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Security.Cryptography.Xml -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Security.Permissions -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Security.Principal.Windows -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.ServiceProcess.ServiceController -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Text.Encodings.Web -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Text.Json -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Threading.Channels -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Windows.Extensions -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• Microsoft.Extensions.DependencyModel -> 5.0.0-preview.3-runtime.20174.7 (parent: Microsoft.Extensions.Logging)
• Microsoft.NETCore.App.Ref -> 5.0.0-preview.3.20174.7 (parent: Microsoft.Extensions.Logging)
• Microsoft.NETCore.App.Internal -> 5.0.0-preview.3.20174.7 (parent: Microsoft.Extensions.Logging)
• Microsoft.NETCore.Platforms -> 5.0.0-preview.3.20174.7 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• Internal.AspNetCore.Analyzers -> 5.0.0-preview.3.20175.1 (parent: Microsoft.AspNetCore.Razor.Language)
• Microsoft.Net.Compilers.Toolset -> 3.6.0-3.20170.19 (parent: Microsoft.Extensions.Logging)

From https://github.com/dotnet/arcade

• Subscription: a6dbb97b-1d09-43d1-e8f9-08d76e1cf1e0
• Build: 20200321.1
• Date Produced: 3/21/2020 1:34 PM
• Commit: 7dbc907fa03eacf4c57f827cb4235d77b7ed4fcd
• Branch: refs/heads/master
• Updates:
  • Microsoft.DotNet.Arcade.Sdk -> 5.0.0-beta.20171.1
  • Microsoft.DotNet.GenAPI -> 5.0.0-beta.20171.1
  • Microsoft.DotNet.Helix.Sdk -> 5.0.0-beta.20171.1

[ghost]

Auto-approving dependency update.

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[Pilchie]

👀

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[Pilchie]

Do we know what's going on here? Tagging @halter73

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[halter73]

All the non-quarantined test failures appear to be in the IIS in-proc StartupTests. Over 30 failures in all, but not every StartupTest. All with the following stack trace:

System.Net.Http.HttpRequestException : An error occurred while sending the request.
---- System.IO.IOException : Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host..
-------- System.Net.Sockets.SocketException : An existing connection was forcibly closed by the remote host.

   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithNtConnectionAuthAsync(HttpConnection connection, HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Server.IntegrationTesting.IIS.LoggingHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in /_/src/Servers/IIS/IntegrationTesting.IIS/src/LoggingHandler.cs:line 32
   at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts, CancellationToken callerToken, Int64 timeoutTime)

I asked @jkotalik about this yesterday to see if he had a theory. He said maybe the dotnet executable isn't being found, but I don't see any concrete evidence of that yet.

@Pilchie should I quarantine all the IIS in-proc StartupTests? Or is rerunning OK since it looks likely to be environmental?

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[Pilchie]

Let's try a re-run in case it's environmental.

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[halter73]

@jkotalik It looks like the StartupTests failures are very consistent. Can you take a look?

@Pilchie Should I quarantine all the StartupTests failures in the meantime? It looks to be about 22 methods all in one test class. My feeling is that I shouldn't given this looks likely to be a regression caused by the dependency update.

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[Pilchie]

Yes, I think it's ok to hold this PR until we understand the failure and get a bug to the right upstream team.

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[BrennanConroy]

Narrowed it down to https://github.com/dotnet/runtime/compare/97d1f9698cfa20054a2909ad2e4e9c4ee20a7520..b0351370ccd132d95c97b75312fc36adaacc2664

And the most likely commit to affect anything relevant is dotnet/runtime@b035137

This line of code is not hit anymore and instead the app crashes

aspnetcore/src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/inprocessapplication.cpp

Line 449 in bd65169

__except(GetExceptionCode() != 0)

Event Viewer:

Faulting application name: iisexpress.exe, version: 10.0.18362.1, time stamp: 0xdb637d68
Faulting module name: ucrtbase.dll, version: 10.0.18362.387, time stamp: 0x4361b720
Exception code: 0xc0000409

With a simple console app before we would get a fault in kernelbase, but now it happens in ucrtbase which is causing issues with ANCM

Simple console app:

Faulting application name: tmp.exe, version: 1.0.0.0, time stamp: 0x5e71cf46
Faulting module name: KERNELBASE.dll, version: 10.0.18362.719, time stamp: 0xb31987d3
Exception code: 0xe0434352

Simple repro with newer hostpolicy.dll vs old hostpolicy.dll:

• dotnet new console
• throw new Exception(); in Main
• Observe event viewer showing fault in ucrtbase instead of kernelbase

@Pilchie Do you know who owns that area?

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[jkotalik]

@elinor-fung / @vitek-karas could you help here?

[jkotalik]

@BrennanConroy thanks for the thorough investigation here.

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❓ Waiting on checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix ARM64 Daily), aspnetcore-ci (Build Tests: Helix x64 Daily), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Test: Windows Server 2016 x64), aspnetcore-ci (Build Build: Windows ARM64), aspnetcore-ci (Build Build: Windows x64/x86), aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[ajaybhargavb]

Some kestrel tests are failing,

• RequestHeaders_MultipleFrames_Accepted(scheme: \"http\")
• DATA_Sent_TooSlowlyDueToSocketBackPressureOnSmallWrite_AbortsConnectionAfterGracePeriod
• FlowControl_ParallelStreams_FirstInFirstOutOrder

@halter73 @jkotalik is this also related to the runtime bug? Or should I create a separate issue for these?

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❓ Waiting on checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64 Daily), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Build: Windows x64/x86), aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[halter73]

is this also related to the runtime bug?

No.

Or should I create a separate issue for these?

These tests are all quarantined.

RequestHeaders_MultipleFrames_Accepted and DATA_Sent_TooSlowlyDueToSocketBackPressureOnSmallWrite_AbortsConnectionAfterGracePeriod have issues already.

I don't think there's an issue for FlowControl_ParallelStreams_FirstInFirstOutOrder yet. @JamesNK Should we create an issue?

[dotnet-maestro]

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

• ✔️ Standard Merge Policies Succeeded - Successful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix ARM64 Daily), aspnetcore-ci (Build Test: Linux Source Build), aspnetcore-ci (Build Tests: Helix x64 Daily), aspnetcore-ci (Build Test: Ubuntu 16.04 x64), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Test: macOS 10.13), aspnetcore-ci (Build Test: Windows Server 2016 x64), aspnetcore-ci (Build Build: Linux Musl ARM64), aspnetcore-ci (Build Build: Linux Musl x64), aspnetcore-ci (Build Build: Linux ARM64), aspnetcore-ci (Build Build: Linux x64), aspnetcore-ci (Build Build: Linux ARM), aspnetcore-ci (Build Build: Windows ARM64), aspnetcore-ci (Build Build: macOS), aspnetcore-ci (Build Build: Windows x64/x86), aspnetcore-ci (Build Build: Windows ARM), aspnetcore-ci (Build Code check), aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.