-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[blazor-wasm] Pass access token as query string when running SignalR in the browser #20115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
dc1aa2a
c14b0bf
05cf101
5ca0f1b
a03cb87
dd7a83c
348d79b
e0af487
e70e52d
6272fa3
4a56599
f83f5ef
9908f8a
7d931f6
f9341c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -66,6 +66,9 @@ private static class Log | |||||||
private static readonly Action<ILogger, HttpTransportType, Exception> _transportStarted = | ||||||||
LoggerMessage.Define<HttpTransportType>(LogLevel.Debug, new EventId(18, "TransportStarted"), "Transport '{Transport}' started."); | ||||||||
|
||||||||
private static readonly Action<ILogger, Exception> _serverSentEventsNotSupportedByBrowser = | ||||||||
LoggerMessage.Define(LogLevel.Debug, new EventId(19, "ServerSentEventsNotSupportedByBrowser"), "Skipping ServerSentEvents because they are not supported by the browser."); | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should I change https://github.com/dotnet/aspnetcore/pull/20115/files#diff-0d9edc1e2ea2a38f9a4be7f30733cc9eR61 as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't know what line you're trying to point out There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Whoops aspnetcore/src/SignalR/clients/csharp/Http.Connections.Client/src/HttpConnection.Log.cs Line 61 in 9908f8a
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, we can just keep both as is. Not too picky There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The difference is that WebSockets is the name of a transport and a name for the type of socket. In that latter sense, that could be plural. ServerSentEvents is just the name of a transport, so it should probably be singular. Super nitpicky though. |
||||||||
|
||||||||
public static void Starting(ILogger logger) | ||||||||
{ | ||||||||
_starting(logger, null); | ||||||||
|
@@ -167,6 +170,11 @@ public static void TransportStarted(ILogger logger, HttpTransportType transportT | |||||||
{ | ||||||||
_transportStarted(logger, transportType, null); | ||||||||
} | ||||||||
|
||||||||
public static void ServerSentEventsNotSupportedByBrowser(ILogger logger) | ||||||||
{ | ||||||||
_serverSentEventsNotSupportedByBrowser(logger, null); | ||||||||
} | ||||||||
} | ||||||||
} | ||||||||
} |
Uh oh!
There was an error while loading. Please reload this page.