Improve support to the dictionary returned by ParseQuery #20133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng>> queryString) public Also update the summary of AddQueryString(string uri, IDictionary<string, string> queryString)
FranklinWhale
requested review from
analogrelay,
jkotalik and
Tratcher
as code owners
ghost
added
the
|
|
Tratcher
reviewed
Mar 25, 2020
|
Reference assemblies need updating. |
FranklinWhale
changed the title
…ing, StringValues>> queryString)
davidfowl
reviewed
Mar 27, 2020
|
@Tratcher I think this PR is ready for review again. Thanks! |
campersau
reviewed
Mar 27, 2020
Co-Authored-By: campersau <[email protected]>
Tratcher
reviewed
Mar 27, 2020
Co-Authored-By: Chris Ross <[email protected]>
Co-Authored-By: Chris Ross <[email protected]>
|
@Tratcher I have removed the brackets in the test cases. Unfortunately, getting this PR to pass all CI tests seems very difficult... |
Tratcher
approved these changes
Mar 31, 2020
|
Thanks |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
AddQueryString(string uri, IEnumerable<KeyValuePair<string, string>> queryString)publicAddQueryString(string uri, IEnumerable<KeyValuePair<string, StringValues>> queryString)AddQueryString(string uri, IDictionary<string, string> queryString)QueryBuilder(IEnumerable<KeyValuePair<string, StringValues>> parameters)Addresses #7945