Skip to content

Include third-party-notices.txt in all packages #20166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Mar 25, 2020

Resolves #20086

Explicitly includes Third-Party-Notices.txt in all packages, and allows packages to use a custom third-party-notices.txt file if they so choose (Identity.UI and the Components packages currently do so). Also includes the version.txt file that was missing from the shared framework

@wtgodbe wtgodbe requested review from analogrelay, Pilchie, HaoK and a team March 25, 2020 23:05
Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but let's verify the build artifacts when available.

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 25, 2020

Will do. I took a look at the artifacts on my box & they looked good, but will re-verify w/ the stuff from CI

@dougbu
Copy link
Contributor

dougbu commented Mar 26, 2020

How will we keep the Identity/UI and Components files up-to-date @mkArtakMSFT (especially after this change gets into 'master')❔ And, is there a way to automatically verify the files are complete close to release time?

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 26, 2020

The packages here look correct to me. @safern @ericstj @ViktorHofer does dotnet/runtime do any package testing to validate that files like third-party-notices.txt are actually being included?

@Pilchie Pilchie added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Mar 26, 2020
@ericstj
Copy link
Member

ericstj commented Mar 26, 2020

We do some package testing but we don't have tests around those additional files, however we do include them in the dotnet/runtime packages. It wouldn't be difficult to add such a test to our validation.

@ericstj
Copy link
Member

ericstj commented Mar 26, 2020

Actually, I see we have in our nuget packages, but not in the shared framework. @dagood @NikolaMilosavljevic we might want to fix that.

@dagood
Copy link
Member

dagood commented Mar 26, 2020

Installing the .NET Core Runtime places "C:\Program Files\dotnet\ThirdPartyNotices.txt" down alongside the host. Installing it with the sharedfx too might be good for side-by-side installs to get a per-version TPN file, but not sure if it's necessary. @leecow @nakarnam

@dagood
Copy link
Member

dagood commented Mar 26, 2020

The goal in the past has seemed to be that "C:\Program Files\dotnet\ThirdPartyNotices.txt" contains data for everything in the directory: dotnet/runtime#3619.

@wtgodbe wtgodbe merged commit 1040be3 into release/3.1 Mar 27, 2020
@wtgodbe wtgodbe deleted the wtgodbe/packagefiles branch March 27, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants