Update branding to 2.1.18 #20171
Merged
Update branding to 2.1.18 #20171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
approved these changes
Mar 26, 2020
dougbu
reviewed
Mar 26, 2020
| @@ -60,4 +60,8 @@ Later on, this will be checked using this condition: | |||
| <PackagesInPatch> | |||
| </PackagesInPatch> | |||
| </PropertyGroup> | |||
| <PropertyGroup Condition=" '$(VersionPrefix)' == '2.1.18' "> | |||
There was a problem hiding this comment.
FYI it's fine to reuse an empty <PropertyGroup> for the previous servicing release. But, not worth further changes.
Pilchie
added
the
area-infrastructure
|
CI is green but hasn't yet reported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't follow https://github.com/dotnet/aspnetcore-internal/blob/master/docs/engineering/servicing-and-preview-fixes.md after today's difficulties - will make sure the merge bot gets this up into master