Pass CancellationToken to WaitAsync in client #20210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Mar 27, 2020
| @@ -601,7 +601,7 @@ async Task OnStreamCanceled(InvocationRequest irq) | |||
| var readers = default(Dictionary<string, object>); | |||
|
|
|||
| CheckDisposed(); | |||
| var connectionState = await _state.WaitForActiveConnectionAsync(nameof(StreamAsChannelCoreAsync)); | |||
| var connectionState = await _state.WaitForActiveConnectionAsync(nameof(StreamAsChannelCoreAsync), token: cancellationToken); | |||
There was a problem hiding this comment.
Can we remove token = default from all of our internal methods that wait for the semaphore like WaitForActiveConnectionAsync, SendWithLock, WaitConnectionLockAsync, etc...?
I know WaitConnectionLockAsync in particular has a lot of usages where we don't want to use a cancellation token for close/reconnect logic, but I like being explicit.
halter73
approved these changes
Mar 30, 2020
|
Be aware, branching is underway. I think we can still get this in to preview3 but likely have to retarget. |
|
/azp run |
|
Switched base and re-running pipeline |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@dotnet/aspnet-build @Pilchie are we OK to merge to preview3? We'd really like to get this in to preview3 if we can (it's not essential but would be nice to not have to wait a month ;)). |
|
Go for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12882