Skip to content

Conditionally enable/disable targeting pack tests #20255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 29, 2020
Merged

Conditionally enable/disable targeting pack tests #20255

merged 5 commits into from
Mar 29, 2020

Conversation

JunTaoLuo
Copy link
Contributor

Addresses part of #14832.

@ghost ghost added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Mar 27, 2020
@JunTaoLuo JunTaoLuo requested a review from a team March 27, 2020 21:04
wtgodbe
wtgodbe reviewed Mar 27, 2020
View reviewed changes
dougbu
dougbu approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me though you should retry to make sure the tests are skipped correctly on the platform where the CI hit a 503.

@dougbu
Copy link
Contributor

dougbu commented Mar 27, 2020

Please also submit a test (public) build with IsTargetingPackBuilding set to true e.g. duplicating whatever run you want and adding that variable. Should confirm tests do something -- perhaps w/ temporary logging after the return.

@JunTaoLuo JunTaoLuo force-pushed the johluo/conditional-ref-tests2 branch from 6f53b79 to 3c56a61 Compare March 28, 2020 03:58
@JunTaoLuo
Copy link
Contributor Author

Verified that it works as intended via file logging. I'll remove the logging code and merge.

@JunTaoLuo JunTaoLuo merged commit 306ef04 into release/3.1 Mar 29, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/conditional-ref-tests2 branch March 29, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees
No one assigned
Labels
feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JunTaoLuo @dougbu @wtgodbe