Skip to content

Fix Helix log upload #20258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2020
Merged

Fix Helix log upload #20258

merged 2 commits into from
Mar 28, 2020

Conversation

BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Mar 27, 2020 •
edited
Loading

No clue what shopt -s globstar is but it wasn't working in some environments.

@BrennanConroy BrennanConroy added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 27, 2020
@BrennanConroy BrennanConroy added this to the 5.0.0-preview3 milestone Mar 27, 2020
@BrennanConroy BrennanConroy requested a review from JunTaoLuo March 27, 2020 22:27
@BrennanConroy BrennanConroy mentioned this pull request Mar 27, 2020
Closed
HaoK
HaoK approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@HaoK HaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shopt -s globstar is what lets you do the **/*.log syntax

@BrennanConroy BrennanConroy merged commit 2766f20 into master Mar 28, 2020
@BrennanConroy BrennanConroy deleted the brecon/testlog branch March 28, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoK HaoK HaoK approved these changes

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
5.0.0-preview3
Development

Successfully merging this pull request may close these issues.
2 participants
@BrennanConroy @HaoK