Quarantine flaky tests #20261
Merged
Quarantine flaky tests #20261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
JunTaoLuo
reviewed
Mar 28, 2020
| @@ -24,7 +24,7 @@ public BlazorServerTemplateTest(ProjectFactoryFixture projectFactory, BrowserFix | |||
|
|
|||
| public Project Project { get; private set; } | |||
|
|
|||
| [ConditionalFact] | |||
| [ConditionalFact(Skip = "This test ran for over an hour")] | |||
There was a problem hiding this comment.
It's starting to feel like all the template tests can timeout.
There was a problem hiding this comment.
I don't think so, when you quarantined the grpc one you didn't do these 2 even though they showed up. And now they're showing up on their own. The rest of the template tests have yet to show these kinds of timeouts.
Pilchie
approved these changes
Mar 28, 2020
|
Thanks @BrennanConroy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template_Produces_The_Right_Set_Of_FilesAsync: https://dev.azure.com/dnceng/public/_build/results?buildId=577215&view=ms.vss-test-web.build-test-results-tab&runId=18127966&paneView=debug&resultId=120453
Related issue: #20219
BlazorServerTemplateWorks_NoAuth and EmptyWebTemplateCSharp: https://dev.azure.com/dnceng/internal/_build/results?buildId=574867
Related issue: #19979