Skip to content

Reeanble dataprotection test #20319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2020
Merged

Reeanble dataprotection test #20319

merged 5 commits into from
Mar 31, 2020

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Mar 30, 2020

Fixes #6720

@ghost ghost added the area-dataprotection Includes: DataProtection label Mar 30, 2020
@HaoK HaoK marked this pull request as ready for review March 31, 2020 05:33
@HaoK HaoK requested a review from a team March 31, 2020 05:33
@HaoK HaoK changed the title Debug dataprotection test Reeanble dataprotection test Mar 31, 2020
@HaoK
Copy link
Member Author

HaoK commented Mar 31, 2020

Looks like this issue with X509store has been fixed so this test can be reenabled

@HaoK
Copy link
Member Author

HaoK commented Mar 31, 2020

Actually there was 2, so making sure both pass

@HaoK
Copy link
Member Author

HaoK commented Mar 31, 2020

There's still a weird OSX specific failure on this one test, @blowdart do you know if there's something special about certs and OSX, I know we saw similar quirky issues with the Cert auth as well, with OSX being finicky about how certs are constructued.

The System_UsesProvidedDirectoryAndCertificate is failing with

Interop+AppleCrypto+AppleCommonCryptoCryptographicException : User interaction is not allowed.

I'll reenable the tests on all the other queues, and leave the issue open to follow up with this failure

@blowdart
Copy link
Contributor

Oh yea, apple really screwed over certs in the new OS. Maybe @bartonjs has some ideas here

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as long as you revert the ci.yml changes before merging

@HaoK HaoK merged commit 15d5ffe into master Mar 31, 2020
@HaoK HaoK deleted the haok/helix/dp branch March 31, 2020 18:36
@bartonjs
Copy link
Member

@HaoK The "user interaction" error means (as far as I understand) that the user account has not yet unlocked their keychain (which happens on a GUI login, but apparently not an SSH login, when it's marked as auto-unlock). The keychain is locked, but since the current application is not running in a UI session it can't pop up the keychain unlock dialog.

You might be able to adjust it in automation via security unlock-keychain <other arguments go here, that I don't remember>.

Alternatively, try to avoid modifying X509Store in tests. (Use the new API for contextual root trust instead of adding to the root stores; pass certificates explicitly instead of using store-enumeration inference... yeah, you probably need tests for those other modes, too... but maybe they're OK being on a more opportunistic/manual loop)

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-dataprotection Includes: DataProtection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Helix] Cert tests fail with user interaction on OSX
4 participants