-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Reeanble dataprotection test #20319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reeanble dataprotection test #20319
Conversation
Looks like this issue with X509store has been fixed so this test can be reenabled |
Actually there was 2, so making sure both pass |
There's still a weird OSX specific failure on this one test, @blowdart do you know if there's something special about certs and OSX, I know we saw similar quirky issues with the Cert auth as well, with OSX being finicky about how certs are constructued.
I'll reenable the tests on all the other queues, and leave the issue open to follow up with this failure |
Oh yea, apple really screwed over certs in the new OS. Maybe @bartonjs has some ideas here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine as long as you revert the ci.yml changes before merging
@HaoK The "user interaction" error means (as far as I understand) that the user account has not yet unlocked their keychain (which happens on a GUI login, but apparently not an SSH login, when it's marked as auto-unlock). The keychain is locked, but since the current application is not running in a UI session it can't pop up the keychain unlock dialog. You might be able to adjust it in automation via Alternatively, try to avoid modifying X509Store in tests. (Use the new API for contextual root trust instead of adding to the root stores; pass certificates explicitly instead of using store-enumeration inference... yeah, you probably need tests for those other modes, too... but maybe they're OK being on a more opportunistic/manual loop) |
Fixes #6720