Skip to content

Always generate checksums as last part of publish job #20367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 1, 2020

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Mar 31, 2020

My first iteration of publishing checksums for this repo didn't work, since it generated checksums for some assets, before those assets were signed (specifically the installer zips). Instead, I'm here trying to ensure that checksums are only generated once per build, after all build and signing jobs are done. I'm using the assumption that the step that passes _PublishArgs is always the final build step, and therefore we can safely hook the checksum target into AfterSigning.proj in that leg (note that only the winx64/x86 job has multiple build steps - all the other jobs just run build once & pass _PublishArgs to that).

This should generate checksums for the same set of assets as my previous solution.

Internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=581767

Resolves part of #18792 (still need to port this to master, and find another solution for 2.1)

@wtgodbe wtgodbe requested review from Pilchie, mthalman and a team March 31, 2020 17:35
@@ -0,0 +1,17 @@
<Project>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 31, 2020

Initial build didn't work since AfterSigning.targets doesn't import root d.b.props, so it didn't have some properties I was expecting it to. New build: https://dev.azure.com/dnceng/internal/_build/results?buildId=581882

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 31, 2020

Last build didn't work either, because AfterSigning.proj in Arcade doesn't import the Arcade SDK props/targets files. New build: https://dev.azure.com/dnceng/internal/_build/results?buildId=582051

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 31, 2020

New build with a tailored list of extensions to generate checksums for: https://dev.azure.com/dnceng/internal/_build/results?buildId=582357

Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no expert on the product build side of things but things seem fine to me.

@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 1, 2020

snipster

Here's the set of checksums that got published - I'm working on verifying that they're valid. @dougbu @JunTaoLuo @mthalman any last concerns with the content of the PR, or the content of what it generated?

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits and questions but only one "should fix". I don't need to review again though I am interested in the questions.

@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 1, 2020

I validated that the checksums are correct this time (w/ $(Get-FileHash <filepath> -Algorithm SHA512).Hash, but noticed that I missed the .rpm and .wixlib files. I'll add those.

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 1, 2020
@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 1, 2020

New build which should include wixlib/rpm checksums: https://dev.azure.com/dnceng/internal/_build/results?buildId=583841

@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 1, 2020

@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 1, 2020

Yarn endpoint exploded. I'll hit retry when I can

Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but otherwise looks good.

@wtgodbe wtgodbe merged commit 2d6827a into release/3.1 Apr 1, 2020
@wtgodbe wtgodbe deleted the wtgodbe/FixChecksums branch April 1, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants