-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Always generate checksums as last part of publish job #20367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,17 @@ | |||
<Project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial build didn't work since |
Last build didn't work either, because |
New build with a tailored list of extensions to generate checksums for: https://dev.azure.com/dnceng/internal/_build/results?buildId=582357 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no expert on the product build side of things but things seem fine to me.
Here's the set of checksums that got published - I'm working on verifying that they're valid. @dougbu @JunTaoLuo @mthalman any last concerns with the content of the PR, or the content of what it generated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits and questions but only one "should fix". I don't need to review again though I am interested in the questions.
I validated that the checksums are correct this time (w/ |
New build which should include wixlib/rpm checksums: https://dev.azure.com/dnceng/internal/_build/results?buildId=583841 |
Yarn endpoint exploded. I'll hit retry when I can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but otherwise looks good.
My first iteration of publishing checksums for this repo didn't work, since it generated checksums for some assets, before those assets were signed (specifically the installer zips). Instead, I'm here trying to ensure that checksums are only generated once per build, after all build and signing jobs are done. I'm using the assumption that the step that passes
_PublishArgs
is always the final build step, and therefore we can safely hook the checksum target intoAfterSigning.proj
in that leg (note that only the winx64/x86 job has multiple build steps - all the other jobs just runbuild
once & pass_PublishArgs
to that).This should generate checksums for the same set of assets as my previous solution.
Internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=581767
Resolves part of #18792 (still need to port this to master, and find another solution for 2.1)