Skip to content

Quarantine BlazorServerTemplateWorks_IndividualAuth #20377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2020
Merged

Quarantine BlazorServerTemplateWorks_IndividualAuth #20377

merged 1 commit into from
Apr 1, 2020

Conversation

jkotalik
Copy link
Contributor

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 31, 2020
@jkotalik
Copy link
Contributor Author

@mkArtakMSFT can you approve?

Pilchie
Pilchie approved these changes Mar 31, 2020
View reviewed changes
src/ProjectTemplates/test/BlazorServerTemplateTest.cs
@@ -85,6 +85,7 @@ public async Task BlazorServerTemplateWorks_NoAuth()
[InlineData(true)]
[InlineData(false)]
[SkipOnHelix("ef restore no worky")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaoK is this still relevant?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skip is still needed because selenium isn't working yet, so the reason is wrong, but the test still doesn't work yet

@jkotalik jkotalik merged commit 85b1a73 into master Apr 1, 2020
@jkotalik jkotalik deleted the jkotalik/quarantineBlazorTemplateTest branch April 1, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoK HaoK HaoK left review comments

@Pilchie Pilchie Pilchie approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotalik @Pilchie @HaoK