Quarantining tests #20631
Merged
Quarantining tests #20631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
requested review from
analogrelay,
halter73,
jkotalik and
Tratcher
as code owners
|
👀 |
dougbu
approved these changes
Apr 8, 2020
jkotalik
approved these changes
Apr 8, 2020
pranavkm
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quarantining tests that have been flaky as reported by whatsbroken as of build https://dev.azure.com/dnceng/public/_build/results?buildId=591163&view=results.
FYI, I did not quarantine the Microsoft.AspNetCore.NodeServices.Tests since the underlying issue was a CDN outage for nodejs.org. There has been discussion on making this more reliable at #20577. I'm not sure if the tradeoff for test coverage vs reliability makes it worthwhile to quarantine all node tests.