Skip to content

Reenable sharedfx with arm64 queue skipped #20659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2020
Merged

Reenable sharedfx with arm64 queue skipped #20659

merged 5 commits into from
Apr 9, 2020

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Apr 8, 2020

No description provided.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 8, 2020
@HaoK HaoK changed the title Try to repro sharedfx failures Reenable sharedfx with arm64 queue skipped Apr 9, 2020
@HaoK HaoK mentioned this pull request Apr 9, 2020
Closed
@HaoK HaoK marked this pull request as ready for review April 9, 2020 16:56
@HaoK HaoK requested a review from a team April 9, 2020 16:56
@HaoK
Copy link
Member Author

HaoK commented Apr 9, 2020

Reenables the shared fx tests, but skips them on helix arm since these tests don't actually test anything that varies on platform

dougbu
dougbu approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the #20669 fix too, correct? (Why isn't the current runtests.sh file causing problems in this PR? Does the assignment work when the value is 0?)

src/Framework/test/Microsoft.AspNetCore.App.UnitTests.csproj
<VerifyAncmBinary Condition="'$(TargetOsName)' == 'win' AND '$(TargetArchitecture)' != 'arm'">true</VerifyAncmBinary>
<TestDependsOnAspNetRuntime>true</TestDependsOnAspNetRuntime>
<TestDependsOnAspNetRef>true</TestDependsOnAspNetRef>
<SkipHelixArm>true</SkipHelixArm>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm: This is the only change from the prior PR reneabling the SharedFx tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'll add the fix runtests fix and back out the extra queues

@HaoK HaoK merged commit 200f2c4 into master Apr 9, 2020
@HaoK HaoK deleted the haok/fxarm branch April 9, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoK @dougbu