[Helix] Install aspnet runtime as part of test runner #20693
Conversation
ghost
added
the
area-infrastructure
|
Marking as ready for review since it looks like the remaining issues are just due to disk space timeouts/unrelated failures |
| File.Copy(file, Path.Combine(appRuntimePath, Path.GetFileName(file)), overwrite: true); | ||
| foreach (var entry in archive.Entries) | ||
| { | ||
| // These are the only extensions that end up in the shared fx directory |
There was a problem hiding this comment.
Is it important to filter based on extension?
There was a problem hiding this comment.
We could just flatten and dump all the files I guess, I mostly was just trying to mimic what the final contents of the shared framework directory has. There's a bunch of other metadata in other folders that aren't really relevant. This was a little cleaner than filtering for relative paths since we'd have to build those based on target framework and other things
| <Command Condition="$(IsWindowsHelixQueue)">call runtests.cmd $(TargetFileName) $(NETCoreSdkVersion) $(MicrosoftNETCoreAppRuntimeVersion) $(_HelixFriendlyNameTargetQueue) $(TargetArchitecture) $(RunQuarantinedTests) $(DotnetEfPackageVersion)</Command> | ||
| <Command Condition="!$(IsWindowsHelixQueue)">./runtests.sh $(TargetFileName) $(NETCoreSdkVersion) $(MicrosoftNETCoreAppRuntimeVersion) $(_HelixFriendlyNameTargetQueue) $(TargetArchitecture) $(RunQuarantinedTests) $(DotnetEfPackageVersion)</Command> | ||
| <Command Condition="$(IsWindowsHelixQueue)">call runtests.cmd $(TargetFileName) $(NETCoreSdkVersion) $(MicrosoftNETCoreAppRuntimeVersion) $(_HelixFriendlyNameTargetQueue) $(TargetArchitecture) $(RunQuarantinedTests) $(DotnetEfPackageVersion) Microsoft.AspNetCore.App.Runtime.win-x64.$(AppRuntimeVersion).nupkg Microsoft.AspNetCore.App.Ref.$(AppRuntimeVersion).nupkg</Command> | ||
| <Command Condition="!$(IsWindowsHelixQueue)">./runtests.sh $(TargetFileName) $(NETCoreSdkVersion) $(MicrosoftNETCoreAppRuntimeVersion) $(_HelixFriendlyNameTargetQueue) $(TargetArchitecture) $(RunQuarantinedTests) $(DotnetEfPackageVersion) Microsoft.AspNetCore.App.Runtime.win-x64.$(AppRuntimeVersion).nupkg Microsoft.AspNetCore.App.Ref.$(AppRuntimeVersion).nupkg</Command> |
There was a problem hiding this comment.
Why are we passing a windows nupkg to Unix?
There was a problem hiding this comment.
Long term we still need to do the work to build all the appropriate shared frameworks and match them to the appropriate helix queues, but today the tests only use managed code so it doesn't seem to matter (yet?)
There was a problem hiding this comment.
This issue basically: #11128
Fixes #20624
Nuke more scripts and add more functionality into test runner