Skip to content

Use encodeURIComponent instead of encodeURI to support returnURLs with many query params #20874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

Use encodeURIComponent instead of encodeURI to support returnURLs with many query params #20874

merged 1 commit into from
Apr 22, 2020

Conversation

georgend
Copy link
Contributor

@georgend georgend commented Apr 15, 2020 •
edited
Loading

@georgend
Use encodeURIComponent instead of encodeURI to support returnURLs wit…
2f5acfb 
…h more than one query

When return URLs query parameters such as
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 15, 2020
@georgend georgend marked this pull request as ready for review April 15, 2020 20:41
mkArtakMSFT
mkArtakMSFT approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @finsharp.

@mkArtakMSFT mkArtakMSFT merged commit 2456e19 into dotnet:master Apr 22, 2020
@georgend
Copy link
Contributor Author

First aspnetcore contribution. Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgend @mkArtakMSFT