Skip to content

Use System.Text.Json's copy ctor #21016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

Use System.Text.Json's copy ctor #21016

merged 1 commit into from
Apr 20, 2020

Conversation

pranavkm
Copy link
Contributor

No description provided.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 20, 2020
@pranavkm pranavkm requested a review from jozkee April 20, 2020 15:49
@pranavkm pranavkm added this to the 5.0.0-preview4 milestone Apr 20, 2020
@davidfowl
Copy link
Member

Is this something we should patch?

@pranavkm
Copy link
Contributor Author

The copy ctor and the property being tested are new in 5.0.

@davidfowl
Copy link
Member

I see

rynowak
rynowak reviewed Apr 20, 2020
View reviewed changes
src/Mvc/Mvc.Core/src/Formatters/SystemTextJsonOutputFormatter.cs
jsonSerializerOptions = new JsonSerializerOptions(jsonSerializerOptions)
{
Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the new CreateForWeb option uses the right defaults and then we don't need this at all 👀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rynowak @pranavkm It seems like you want us to include this in the new JsonSerializerOptions for web. So, the web options will have PropertyNameCaseInsensitive = true, PropertyNamingPolicy = JsonNamingPolicy.CamelCase, and Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping.

Is that correct?

I also pointed this out on dotnet/runtime#34626 (comment) in case you missed it.
cc @layomia

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also cc @terrajobst.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, when I spoke to @GrabYourPitchforks, the recommendation was that using UnsafeRelaxedJsonEscaping is only safe if the JSON wasn't interspersed with markup. Web might not convey that this is meant for REST \ API scenarios.

jozkee
jozkee approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@jozkee jozkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pranavkm pranavkm merged commit 4191eb5 into master Apr 20, 2020
@pranavkm pranavkm deleted the prkrishn/copy-ctor branch April 20, 2020 18:14
@jozkee jozkee mentioned this pull request May 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layomia layomia layomia left review comments

@jozkee jozkee jozkee approved these changes

@rynowak rynowak rynowak approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
5.0.0-preview4
Development

Successfully merging this pull request may close these issues.
5 participants
@pranavkm @davidfowl @rynowak @layomia @jozkee