Fix race in gRPC interop test logging #21080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
approved these changes
Apr 22, 2020
|
Why aren't the tests marked with |
dougbu
added a commit
that referenced
this pull request
Apr 22, 2020
- see also #21080 for another recent failure
dougbu
added a commit
that referenced
this pull request
Apr 22, 2020
- see also #21080 for another recent failure
|
@dougbu I removed the code that was failing so this failure mode can't possibly occur. I think there's no need to add the quarantine attribute. |
|
Probably need to rerun the whole thing to pick up the linux arm64 agent change |
|
I don't see any reason to block this PR on that since the failure is unrelated, so I'm just going to merge as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing the flakiness issue as discussed offline, I decided to remove it all together. Given that the server logs are already captured via ITestOutputHelper, there's no need for the additional logging logic. These logs are a relic of the time when we only had one server for the entire test suite and wanted a separate server log.