Skip to content

Unskip BlazorServerTemplateWorks_IndividualAuth test #21286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Apr 28, 2020

I propose we undo skipping this test, see if the hangs happen again, then attempt to debug once we have the appropriate artifacts from a failing build.

There's no useful process dumps in the build linked in the issue referenced below. Also, I reran the PR build three times and wasn't able to reproduce the original hang that was reported.

Addresses #20520

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 28, 2020
@captainsafia captainsafia added area-blazor Includes: Blazor, Razor Components test-failure and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Apr 28, 2020
@captainsafia captainsafia reopened this Apr 28, 2020
@captainsafia captainsafia reopened this Apr 28, 2020
@captainsafia captainsafia marked this pull request as ready for review April 28, 2020 23:00
@captainsafia captainsafia changed the title De-quarantine BlazorServerTemplateWorks_IndividualAuth test Unskip BlazorServerTemplateWorks_IndividualAuth test Apr 29, 2020
@mkArtakMSFT
Copy link
Contributor

mkArtakMSFT commented Apr 30, 2020

Thanks Safia.
Agree. These have been passing 100% for more than a month now. Let's un-quarantine and watch closely.

Ignore this, I mixed it with a different test

@captainsafia captainsafia merged commit 8271204 into master Apr 30, 2020
@captainsafia captainsafia deleted the safia/fix-test branch April 30, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components test-failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants