Skip to content

Fix package overrides #21329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2020
Merged

Fix package overrides #21329

merged 2 commits into from
Apr 30, 2020

Conversation

JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Apr 29, 2020 •
edited by dougbu
Loading

I noticed that the extensions packages from dotnet/runtime didn't have the correct entries in PackageOverrides.txt of the targeting pack. I'm still working on adding other targeting pack tests but I figured this should probably be fixed without waiting for the rest of the tests. The cause of this error was that the property MicrosoftInternalExtensionsRefsPackageOverrideVersion (for example defined here) was removed at some point and the targeting pack's use of it wasn't updated. I'm changing it to use the same version as the transport package that contains the reference assemblies.

FYI, the current PackageOverrides looke like:

Microsoft.Win32.Registry|5.0.0-preview.5.20225.8
System.Diagnostics.EventLog|5.0.0-preview.5.20225.8
System.IO.Pipelines|5.0.0-preview.5.20225.8
System.Security.AccessControl|5.0.0-preview.5.20225.8
System.Security.Cryptography.Cng|5.0.0-preview.5.20225.8
System.Security.Cryptography.Xml|5.0.0-preview.5.20225.8
System.Security.Permissions|5.0.0-preview.5.20225.8
System.Security.Principal.Windows|5.0.0-preview.5.20225.8
System.Windows.Extensions|5.0.0-preview.5.20225.8
Microsoft.Extensions.Caching.Abstractions|
Microsoft.Extensions.Caching.Memory|
Microsoft.Extensions.Configuration.Abstractions|
Microsoft.Extensions.Configuration.Binder|
Microsoft.Extensions.Configuration.CommandLine|
Microsoft.Extensions.Configuration|
Microsoft.Extensions.Configuration.EnvironmentVariables|
Microsoft.Extensions.Configuration.FileExtensions|
Microsoft.Extensions.Configuration.Ini|
Microsoft.Extensions.Configuration.Json|
Microsoft.Extensions.Configuration.UserSecrets|
Microsoft.Extensions.Configuration.Xml|
Microsoft.Extensions.DependencyInjection.Abstractions|
Microsoft.Extensions.DependencyInjection|
Microsoft.Extensions.FileProviders.Abstractions|
Microsoft.Extensions.FileProviders.Composite|
Microsoft.Extensions.FileProviders.Physical|
Microsoft.Extensions.FileSystemGlobbing|
Microsoft.Extensions.Hosting.Abstractions|
Microsoft.Extensions.Hosting|
Microsoft.Extensions.Http|
Microsoft.Extensions.Logging.Abstractions|
Microsoft.Extensions.Logging.Configuration|
Microsoft.Extensions.Logging.Console|
Microsoft.Extensions.Logging.Debug|
Microsoft.Extensions.Logging|
Microsoft.Extensions.Logging.EventLog|
Microsoft.Extensions.Logging.EventSource|
Microsoft.Extensions.Logging.TraceSource|
Microsoft.Extensions.Options.ConfigurationExtensions|
Microsoft.Extensions.Options.DataAnnotations|
Microsoft.Extensions.Options|
Microsoft.Extensions.Primitives|
Microsoft.AspNetCore.Antiforgery|5.0.0
Microsoft.AspNetCore.Authentication.Abstractions|5.0.0
Microsoft.AspNetCore.Authentication.Cookies|5.0.0
Microsoft.AspNetCore.Authentication.Core|5.0.0
Microsoft.AspNetCore.Authentication|5.0.0
Microsoft.AspNetCore.Authentication.OAuth|5.0.0
Microsoft.AspNetCore.Authorization|5.0.0
Microsoft.AspNetCore.Authorization.Policy|5.0.0
Microsoft.AspNetCore.Components.Authorization|5.0.0
Microsoft.AspNetCore.Components|5.0.0
Microsoft.AspNetCore.Components.Forms|5.0.0
Microsoft.AspNetCore.Components.Server|5.0.0
Microsoft.AspNetCore.Components.Web|5.0.0
Microsoft.AspNetCore.Connections.Abstractions|5.0.0
Microsoft.AspNetCore.CookiePolicy|5.0.0
Microsoft.AspNetCore.Cors|5.0.0
Microsoft.AspNetCore.Cryptography.Internal|5.0.0
Microsoft.AspNetCore.Cryptography.KeyDerivation|5.0.0
Microsoft.AspNetCore.DataProtection.Abstractions|5.0.0
Microsoft.AspNetCore.DataProtection|5.0.0
Microsoft.AspNetCore.DataProtection.Extensions|5.0.0
Microsoft.AspNetCore.Diagnostics.Abstractions|5.0.0
Microsoft.AspNetCore.Diagnostics|5.0.0
Microsoft.AspNetCore.Diagnostics.HealthChecks|5.0.0
Microsoft.AspNetCore|5.0.0
Microsoft.AspNetCore.HostFiltering|5.0.0
Microsoft.AspNetCore.Hosting.Abstractions|5.0.0
Microsoft.AspNetCore.Hosting|5.0.0
Microsoft.AspNetCore.Hosting.Server.Abstractions|5.0.0
Microsoft.AspNetCore.Html.Abstractions|5.0.0
Microsoft.AspNetCore.Http.Abstractions|5.0.0
Microsoft.AspNetCore.Http.Connections.Common|5.0.0
Microsoft.AspNetCore.Http.Connections|5.0.0
Microsoft.AspNetCore.Http|5.0.0
Microsoft.AspNetCore.Http.Extensions|5.0.0
Microsoft.AspNetCore.Http.Features|5.0.0
Microsoft.AspNetCore.HttpOverrides|5.0.0
Microsoft.AspNetCore.HttpsPolicy|5.0.0
Microsoft.AspNetCore.Identity|5.0.0
Microsoft.AspNetCore.Localization|5.0.0
Microsoft.AspNetCore.Localization.Routing|5.0.0
Microsoft.AspNetCore.Metadata|5.0.0
Microsoft.AspNetCore.Mvc.Abstractions|5.0.0
Microsoft.AspNetCore.Mvc.ApiExplorer|5.0.0
Microsoft.AspNetCore.Mvc.Core|5.0.0
Microsoft.AspNetCore.Mvc.Cors|5.0.0
Microsoft.AspNetCore.Mvc.DataAnnotations|5.0.0
Microsoft.AspNetCore.Mvc|5.0.0
Microsoft.AspNetCore.Mvc.Formatters.Json|5.0.0
Microsoft.AspNetCore.Mvc.Formatters.Xml|5.0.0
Microsoft.AspNetCore.Mvc.Localization|5.0.0
Microsoft.AspNetCore.Mvc.Razor|5.0.0
Microsoft.AspNetCore.Mvc.RazorPages|5.0.0
Microsoft.AspNetCore.Mvc.TagHelpers|5.0.0
Microsoft.AspNetCore.Mvc.ViewFeatures|5.0.0
Microsoft.AspNetCore.Razor|5.0.0
Microsoft.AspNetCore.Razor.Runtime|5.0.0
Microsoft.AspNetCore.ResponseCaching.Abstractions|5.0.0
Microsoft.AspNetCore.ResponseCaching|5.0.0
Microsoft.AspNetCore.ResponseCompression|5.0.0
Microsoft.AspNetCore.Rewrite|5.0.0
Microsoft.AspNetCore.Routing.Abstractions|5.0.0
Microsoft.AspNetCore.Routing|5.0.0
Microsoft.AspNetCore.Server.HttpSys|5.0.0
Microsoft.AspNetCore.Server.IIS|5.0.0
Microsoft.AspNetCore.Server.IISIntegration|5.0.0
Microsoft.AspNetCore.Server.Kestrel.Core|5.0.0
Microsoft.AspNetCore.Server.Kestrel|5.0.0
Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets|5.0.0
Microsoft.AspNetCore.Session|5.0.0
Microsoft.AspNetCore.SignalR.Common|5.0.0
Microsoft.AspNetCore.SignalR.Core|5.0.0
Microsoft.AspNetCore.SignalR|5.0.0
Microsoft.AspNetCore.SignalR.Protocols.Json|5.0.0
Microsoft.AspNetCore.StaticFiles|5.0.0
Microsoft.AspNetCore.WebSockets|5.0.0
Microsoft.AspNetCore.WebUtilities|5.0.0
Microsoft.Extensions.Configuration.KeyPerFile|5.0.0
Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions|5.0.0
Microsoft.Extensions.Diagnostics.HealthChecks|5.0.0
Microsoft.Extensions.FileProviders.Embedded|5.0.0
Microsoft.Extensions.Identity.Core|5.0.0
Microsoft.Extensions.Identity.Stores|5.0.0
Microsoft.Extensions.Localization.Abstractions|5.0.0
Microsoft.Extensions.Localization|5.0.0
Microsoft.Extensions.ObjectPool|5.0.0
Microsoft.Extensions.WebEncoders|5.0.0
Microsoft.JSInterop|5.0.0
Microsoft.Net.Http.Headers|5.0.0

@JunTaoLuo JunTaoLuo added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Apr 29, 2020
@JunTaoLuo JunTaoLuo requested a review from a team April 29, 2020 17:00
@dougbu
Copy link
Contributor

dougbu commented Apr 29, 2020

And, yes, a test would be helpful

@JunTaoLuo JunTaoLuo requested a review from a team April 30, 2020 17:45
@JunTaoLuo
Copy link
Contributor Author

Test added

@JunTaoLuo JunTaoLuo marked this pull request as ready for review April 30, 2020 17:45
dougbu
dougbu approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JunTaoLuo JunTaoLuo merged commit 2fa0212 into master Apr 30, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/fix-package-override branch April 30, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees
No one assigned
Labels
feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JunTaoLuo @dougbu @wtgodbe