Skip to content

Adds instruction for creating JAVA_HOME env variable #21371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2020
Merged

Adds instruction for creating JAVA_HOME env variable #21371

merged 2 commits into from
May 11, 2020

Conversation

sanyam142mittal
Copy link
Contributor

JAVA_HOME environment variable is required by Gradle. Gradle compilation fails otherwise.

Summary of the changes (Less than 80 chars)

  • Updates docs/BuildFromSource.md to add instruction for adding JAVA_HOME env variable

No bug raised

@sanyam142mittal
Adds instruction for creating JAVA_HOME env variable
5aae034 
JAVA_HOME environment variable is required by Gradle. Gradle compilation fails otherwise.
@Pilchie Pilchie requested review from dougbu and BrennanConroy April 30, 2020 17:30
dougbu
dougbu approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion to make it clear this setting is often not necessary. This is a good doc improvement with or without that.

BrennanConroy
BrennanConroy reviewed Apr 30, 2020
View reviewed changes
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 1, 2020
@dougbu
Copy link
Contributor

dougbu commented May 11, 2020

@BrennanConroy please merge if you agree this is ready. @sanyam142mittal thanks very much❕

@BrennanConroy BrennanConroy merged commit cb83d5d into dotnet:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@BrennanConroy BrennanConroy BrennanConroy left review comments

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanyam142mittal @dougbu @BrennanConroy @Pilchie