Add AuthenticationDisplayName to HttpSys #21410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kahbazi
requested review from
analogrelay,
halter73,
jkotalik and
Tratcher
as code owners
ghost
added
the
Tratcher
reviewed
May 1, 2020
| /// <summary> | ||
| /// Sets the display name shown to users on login pages. The default is null. | ||
| /// </summary> | ||
| public string AuthenticationDisplayName { get; set; } |
There was a problem hiding this comment.
Reference assemblies need updating.
https://github.com/dotnet/aspnetcore/blob/master/docs/ReferenceAssemblies.md
There was a problem hiding this comment.
I couldn't generate reference assembly with scripts, so I just edit the file manually. I hope it works.
|
Wow, that was fast. Did you set up notifications for HelpWanted issues somehow? |
|
No, I it was a normal subscription. I was just online ... and act fast 😁 |
Tratcher
approved these changes
May 1, 2020
|
Hello @Tratcher! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
So close: |
|
Thanks |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21281