Skip to content

Fix NRE in KestrelServerOptions.Listen*() #21467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
May 5, 2020
Merged

Fix NRE in KestrelServerOptions.Listen*() #21467

2 commits merged into from
May 5, 2020

Conversation

halter73
Copy link
Member

@halter73 halter73 commented May 4, 2020

Addresses #21423

@halter73 halter73 requested review from JamesNK and Tratcher May 4, 2020 18:15
@ghost ghost added the area-servers label May 4, 2020
@Tratcher
Copy link
Member

Tratcher commented May 4, 2020

Woops, broke some other tests.

@ghost
Copy link

ghost commented May 5, 2020

Hello @Tratcher!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 4ebf695 into master May 5, 2020
@ghost ghost deleted the halter73/21423 branch May 5, 2020 03:04
@Tratcher Tratcher added this to the 5.0.0-preview5 milestone May 5, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants