Skip to content

Use Encoding.CreateTranscodingStream #21509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2020
Merged

Use Encoding.CreateTranscodingStream #21509

merged 2 commits into from
May 6, 2020

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented May 5, 2020

Fixes #21243

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 5, 2020
@pranavkm pranavkm added this to the 5.0.0-preview4 milestone May 5, 2020
GrabYourPitchforks
GrabYourPitchforks approved these changes May 6, 2020
View reviewed changes
rynowak
rynowak approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks right. We should answer the question you raised before moving forward with this...

@jaredpar jaredpar mentioned this pull request May 6, 2020
Closed
@pranavkm pranavkm merged commit 51f18b5 into master May 6, 2020
@pranavkm pranavkm deleted the prkrishn/21243 branch May 6, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

@rynowak rynowak rynowak approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
5.0.0-preview5
Development

Successfully merging this pull request may close these issues.

Replace MVC's homebrew transcoding stream with System.Text.Encoding.CreateTranscodingStream
3 participants
@pranavkm @rynowak @GrabYourPitchforks