-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Set certificate in some Kestrel tests to avoid global machine state #21516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👀 |
👁️ have a question: What's the advantage of an 👀 question over an 👀 reaction to the PR description and clicking the |
Putting 👀 (or any comment) will add you to the mentions in the email metadata, so you can easily filter issues that you're actually interested in. Kevin told me once that he was subscribed to everything and I am too, I know that I have filters based on the email metadata so adding those kinds of comments are super useful for getting updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have said
Unfortunately https://netcorenativeassets.blob.core.windows.net seems to have been flaky during the build. See also #20577 though a retry will be needed here.
Yep, @BrennanConroy nailed why I use 👀. I get email for anything I'm "participating", but see the rest of my notifications in the GitHub notifications UI. |
We probably want to port this back to 3.1 too |
No disagreement here. It's a test-only change and can therefore be merged whenever the branch is open. @BrennanConroy❔ |
Sure, I'll make a PR for this one |
There were some changes to dev certs which is causing hangs in Kestrel tests in #21017. This is because the tests were relying on the dev cert being allowed globally on the test machine, when they should be providing a cert so they don't rely on global state.
Also added a little bit extra test coverage to the existing tests.