Keep `@(Reference)` metadata when creating `@(ProjectReference)` items #21567

dougbu · 2020-05-07T08:46:33Z

Microsoft.Web.Xdt.Extensions shows up as a package dependency in Microsoft.AspNetCore.AzureAppServices.SiteExtension #20818, fix e.g. references to Microsoft.Web.Xdt.Extensions in our packages
make @(Reference) items much more broadly applicable
emit an error when @(ProjectReference) is used instead of @(Reference)
- then get rid of the errors (!!)
rename a couple of projects to match their assembly names
- then regenerate the @(ProjectReferenceProvider) items
switch intersection approach from Exclude / Exclude to Copy / Update / Copy

Projects of particular interest:

src/DefaultBuilder/src/Microsoft.AspNetCore.csproj
- honouring metadata left e.g. Microsoft.AspNetCore.Components.WebAssembly.DevServer package unchanged
- removed redundant metadata after that confirmation
src/Razor/tools/Microsoft.AspNetCore.Razor.Internal.Transport/
- content of this package unchanged but metadata avoids extra work
- add a comment about the extra work
src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/
- success! removes Microsoft.Web.Xdt.Extensions dependency from the package
src/SiteExtensions/Runtime/Microsoft.AspNetCore.Runtime.SiteExtension.pkgproj
- add a Condition to avoid an ordering issue I hit here
src/Tools/Extensions.ApiDescription.Server/src/
- avoid errors the new build ordering and timing caused

Separately, up the timeout in the <DownloadFile /> task

hit repeated timeouts downloading dotnet-runtime-5.0.0-rc.1.20370.4-win-x64.zip

nits:

remove dupe @(Reference) item in Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj
remove useless %(ProjectReference.IsImplicitlyDefined) metadata as well as its misspellings
remove extra spaces from ProjectReferences.props
clean up a few comments in ResolveReferences.targets

dougbu · 2020-07-31T21:14:31Z

Also building in https://dev.azure.com/dnceng/internal/_build/results?buildId=753395 to create the Microsoft.AspNetCore.AzureAppServices.SiteExtension package.

- #20818, fix e.g. references to Microsoft.Web.Xdt.Extensions in our packages - make `@(Reference)` items much more broadly applicable - emit an error when `@(ProjectReference)` is used instead of `@(Reference)` - then get rid of the errors (!!) - rename a couple of projects to match their assembly names - then regenerate the `@(ProjectReferenceProvider)` items - switch intersection approach from Exclude / Exclude to Copy / Update / Copy Projects of particular interest: - src/DefaultBuilder/src/Microsoft.AspNetCore.csproj - honouring metadata left e.g. Microsoft.AspNetCore.Components.WebAssembly.DevServer package unchanged - removed redundant metadata after that confirmation - src/Razor/tools/Microsoft.AspNetCore.Razor.Internal.Transport/ - content of this package unchanged but metadata avoids extra work - add a comment about the extra work - src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/ - success! removes Microsoft.Web.Xdt.Extensions dependency from the package - src/SiteExtensions/Runtime/Microsoft.AspNetCore.Runtime.SiteExtension.pkgproj - add a `Condition` to avoid an ordering issue I hit here - src/Tools/Extensions.ApiDescription.Server/src/ - avoid errors the new build ordering and timing caused Separately, up the timeout in the `<DownloadFile />` task - hit repeated timeouts downloading dotnet-runtime-5.0.0-rc.1.20370.4-win-x64.zip nits: - remove dupe `@(Reference)` item in Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj - remove useless `%(ProjectReference.IsImplicitlyDefined)` metadata as well as its misspellings - remove extra spaces from ProjectReferences.props - clean up a few comments in ResolveReferences.targets questions about current `@(PackageReference)` items: - why does Internal.AspNetCore.Analyzers project use Microsoft.CodeAnalysis.CSharp.Workspaces v2.8.0? - should we move from Yarn.MSBuild 1.15.2 to 1.22.4 i.e. `yarn` 1.13.0 to 1.22.4? - should `AddContent` target in Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj instead get 5.0 packages? - should we move `MsQuicPackage.*` version from QuicSampleClient and QuicSampleApp projects to eng/Versions.props?

dougbu · 2020-08-03T04:15:28Z

Another internal build at https://dev.azure.com/dnceng/internal/_build/results?buildId=754565

dougbu · 2020-08-03T22:03:29Z

I have double-checked the packages for updated projects and found no differences other than the expected assembly file versions and the #20818 fix. This PR is ready for review.

dougbu · 2020-08-03T22:14:44Z

questions about current @(PackageReference) items:

why does Internal.AspNetCore.Analyzers project use Microsoft.CodeAnalysis.CSharp.Workspaces v2.8.0?
- @JunTaoLuo @pranavkm ❔
should we move from Yarn.MSBuild 1.15.2 to 1.22.4 i.e. yarn 1.13.0 to 1.22.4?
- @javiercn @BrennanConroy ❔
should AddContent target in Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj instead get 5.0 packages?
- @BrennanConroy ❔
should we move MsQuicPackage.* version from QuicSampleClient and QuicSampleApp projects to eng/Versions.props?
- @jkotalik ❔

jkotalik · 2020-08-03T22:19:24Z

MsQuicPackage.*

Sure.

pranavkm · 2020-08-03T22:57:55Z

why does Internal.AspNetCore.Analyzers project use Microsoft.CodeAnalysis.CSharp.Workspaces v2.8.0

I'm not really familiar with that package. @JunTaoLuo would know best

BrennanConroy · 2020-08-04T03:37:36Z

* should `AddContent` target in Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj instead get 5.0 packages?

I'm not really sure what that part is for, but it does look like we should probably update the version.

* should we move from Yarn.MSBuild 1.15.2 to 1.22.4 i.e. `yarn` 1.13.0 to 1.22.4?

No objections here.

wtgodbe · 2020-08-04T16:50:58Z

eng/targets/ResolveReferences.targets

+    <!-- Use only Reference items when project is a reference provider. Simplifies project moves and shortens files. -->
+    <_AllProjectReference Update="@(ProjectReference->'%(Filename)')" DirectUse="1" />
+
+    <_AllProjectReference Update="@(Reference)" Use="1">


Is there a guarantee we'll never need to update this list of metadata?

There are few guarantees in life😈 But, the current list goes pretty far beyond what we're likely to use in *.csproj and *.fsproj projects and should hold us in good stead until and unless new metadata is invented. I included everything I saw used in existing @(Reference) and @(ProjectReference) items in this repo as well as what seemed plausible from the documentation.

wtgodbe

Seems like goodness

dougbu · 2020-08-04T17:07:43Z

I'll file an issue about the changes we could or should make based on the answers to my questions above once we hear from @JunTaoLuo.

JunTaoLuo · 2020-08-05T17:32:21Z

FYI, after our offline discussion, we're going to try updating the TFM of Internal.AspNetCore.Analyzers to target netstandard2.0 TFM so it can consume the same version of the roslyn packages as the rest of the repo. Also good to double check if we plan on removing this package outright at some point.

dougbu · 2020-08-05T22:39:23Z

@pranavkm following up on @JunTaoLuo's comment just above

Also good to double check if we plan on removing this package outright at some point.

I'm double-checking😺 I couldn't find a seemingly-relevant issue about removing the analyzer but also can't find anywhere we're suppressing it other than for analyzers and tools. Do we need this anymore❔

And, if we need it, why is it packaged i.e. is the package just a holdover from when the project was in dotnet/extensions❔

pranavkm · 2020-08-05T23:05:53Z

And, if we need it, why is it packaged i.e. is the package just a holdover from when the project was in dotnet/extensions❔

That seems like the most likely scenario.

I couldn't find a seemingly-relevant issue about removing the analyzer

I think I commented on this in another issue. There's only one analyzer in the package about not exposing pubternal types. We don't have any of those any more so it seems entirely unnecessary.

dougbu · 2020-08-06T00:41:26Z

#24608 covers the follow-up points above

ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 7, 2020

dougbu force-pushed the dougbu/site.extensions.20818 branch from e9e81db to b875f2a Compare May 7, 2020 16:57

dougbu force-pushed the dougbu/site.extensions.20818 branch from b875f2a to 95dc49a Compare July 30, 2020 04:29

dougbu changed the title ~~Move @(Reference) -> @(ProjectReference) conversion into a target~~ Keep @(Reference) metadata when creating @(ProjectReference) items Jul 30, 2020

dougbu force-pushed the dougbu/site.extensions.20818 branch from 95dc49a to f5507b5 Compare July 31, 2020 21:01

dougbu force-pushed the dougbu/site.extensions.20818 branch from f5507b5 to bc3bad0 Compare August 3, 2020 03:53

!fixup! Correct other references to renamed projects

a7a0c67

dougbu marked this pull request as ready for review August 3, 2020 22:01

dougbu requested review from halter73, jkotalik, SteveSandersonMS, Tratcher and a team as code owners August 3, 2020 22:01

dougbu requested a review from a team August 3, 2020 22:01

wtgodbe reviewed Aug 4, 2020

View reviewed changes

wtgodbe approved these changes Aug 4, 2020

View reviewed changes

dougbu merged commit e133683 into master Aug 4, 2020

dougbu deleted the dougbu/site.extensions.20818 branch August 4, 2020 17:05

dougbu mentioned this pull request Aug 6, 2020

Cleanup versions a bit #24608

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Keep `@(Reference)` metadata when creating `@(ProjectReference)` items #21567

Keep `@(Reference)` metadata when creating `@(ProjectReference)` items #21567

Uh oh!

dougbu commented May 7, 2020 •

edited

Loading

Uh oh!

dougbu commented Jul 31, 2020

Uh oh!

dougbu commented Aug 3, 2020

Uh oh!

dougbu commented Aug 3, 2020

Uh oh!

dougbu commented Aug 3, 2020

Uh oh!

jkotalik commented Aug 3, 2020

Uh oh!

pranavkm commented Aug 3, 2020

Uh oh!

BrennanConroy commented Aug 4, 2020

Uh oh!

wtgodbe Aug 4, 2020

Uh oh!

dougbu Aug 4, 2020

Uh oh!

wtgodbe left a comment

Uh oh!

dougbu commented Aug 4, 2020

Uh oh!

JunTaoLuo commented Aug 5, 2020

Uh oh!

dougbu commented Aug 5, 2020

Uh oh!

pranavkm commented Aug 5, 2020 •

edited

Loading

Uh oh!

dougbu commented Aug 6, 2020

Uh oh!

Uh oh!

Keep @(Reference) metadata when creating @(ProjectReference) items #21567

Keep @(Reference) metadata when creating @(ProjectReference) items #21567

Uh oh!

Conversation

dougbu commented May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dougbu commented Jul 31, 2020

Uh oh!

dougbu commented Aug 3, 2020

Uh oh!

dougbu commented Aug 3, 2020

Uh oh!

dougbu commented Aug 3, 2020

Uh oh!

jkotalik commented Aug 3, 2020

Uh oh!

pranavkm commented Aug 3, 2020

Uh oh!

BrennanConroy commented Aug 4, 2020

Uh oh!

wtgodbe Aug 4, 2020

Choose a reason for hiding this comment

Uh oh!

dougbu Aug 4, 2020

Choose a reason for hiding this comment

Uh oh!

wtgodbe left a comment

Choose a reason for hiding this comment

Uh oh!

dougbu commented Aug 4, 2020

Uh oh!

JunTaoLuo commented Aug 5, 2020

Uh oh!

dougbu commented Aug 5, 2020

Uh oh!

pranavkm commented Aug 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dougbu commented Aug 6, 2020

Uh oh!

Uh oh!

Keep `@(Reference)` metadata when creating `@(ProjectReference)` items #21567

Keep `@(Reference)` metadata when creating `@(ProjectReference)` items #21567

dougbu commented May 7, 2020 •

edited

Loading

pranavkm commented Aug 5, 2020 •

edited

Loading