-
Notifications
You must be signed in to change notification settings - Fork 10.4k
aspnetcore-tooling migration #21581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
aspnetcore-tooling migration #21581
Changes from all commits
Commits
Show all changes
411 commits
Select commit
Hold shift + click to select a range
9860cfc
do the needful
ajaybhargavb c21572b
Merge pull request dotnet/aspnetcore-tooling#526 from aspnet/ajbaaska…
ajaybhargavb 9a456a5
Fix crash in functions block (dotnet/aspnetcore-tooling#550)
ajaybhargavb 4a4b800
Enable resx source generation (dotnet/aspnetcore-tooling#561)
natemcmaster 997ab19
Unskip Build_WithViews_ProducesDepsFileWithCompilationContext_ButNoRe…
pranavkm fede538
Port fixes from master (dotnet/aspnetcore-tooling#562)
ajaybhargavb d388f38
Merge remote-tracking branch 'origin/release/vs16.1-preview4'
b9fde95
Fix RazorDiagnostics from being hidden and unordered.
ffd11ea
Add support for single line control flow statements in code blocks.
96475e4
Render more TagHelper code at design time.
b5a7dab
Do build time discovery of MVC ApplicationParts (dotnet/aspnetcore-to…
pranavkm 98a2a43
fixed destructive property assignment (reference self correctly using…
aodl 111e26d
Conditionally enable content items in the razor SDK (dotnet/aspnetcor…
javiercn 13397dd
Initial support for static assets in Razor Class Libraries (dotnet/as…
javiercn 5bad5de
Directive attributes part 1: Support parameters in bound attributes (…
ajaybhargavb 72d017c
Added support for @attribute directive (dotnet/aspnetcore-tooling#607)
ajaybhargavb 95bb698
Make duplicate attribute names an error (dotnet/aspnetcore-tooling#604)
rynowak db66452
Fix bug in bind lowering logic
ajaybhargavb 66dd6b3
Specify UpToDateReloadFileTypes (dotnet/aspnetcore-tooling#611)
pranavkm 68f5fec
Suports discovery of static web assets from referenced projects (dotn…
javiercn f25734a
Support parsing directive attributes - Part 2/2 (dotnet/aspnetcore-to…
ajaybhargavb b45c32f
Add support for source-build (dotnet/aspnetcore-tooling#620)
natemcmaster 33e8098
Remove obsolete project file
1c27d78
Adds support for packing and publishing static web assets
javiercn 5c59b78
Allow UpToDateReloadFileTypes to be modified by packages
pranavkm 9d8e9fb
Allow file watching with dotnet-watch
pranavkm 6be2d3d
Allow UpToDateReloadFileTypes to be modified by packages (dotnet/aspn…
pranavkm c588d53
Use an explicit intermediate node for directive attributes (dotnet/as…
ajaybhargavb 48eeaef
Add Razor component TagHelper detection.
22f593b
[Static Web Assets] Removes support for embedding the development man…
javiercn 2c01615
[Flaky tests] Restore package projects at build time
javiercn 30668fb
Ignore extensible directive nodes coming from Imports when generating…
ajaybhargavb 261b256
Fix error spacing.
c16d55c
Allow `content`, `output` and `context` as keywords to VC params.
060ff0d
Ensure ApplicationPart attributes are added during incremental builds…
pranavkm 64f56b7
For bind on element, also write the updated attribute name to the ren…
SteveSandersonMS 7a510b3
Fixup incremental builds with ApplicationPartsDiscovery (dotnet/aspne…
pranavkm ab867ec
Allow @bind:event override when used with @bind (dotnet/aspnetcore-to…
ajaybhargavb fa65b30
Don't require preceding @ for event handler directive attributes (dot…
ajaybhargavb ef4773a
Add attribute splatting compiler support (dotnet/aspnetcore-tooling#640)
rynowak adfe6f0
Move to 3.0 Preview 6 SDK and 2.1.11 runtime (dotnet/aspnetcore-tooli…
dougbu 19d9dbc
Removes the logic for sanitizing the base path for static web assets …
javiercn 4e16cfd
Use LogErrorFromException when FindAssembliesWithReferencesTo throws …
pranavkm 0659180
Do case insensitive comparison in DefaultRazorProjectFileSystem.GetIt…
ajaybhargavb 895ad89
Fix: dotnet/aspnetcore-tooling#11197 automatic backing-field for @ref…
rynowak 2c6e1da
Use ref-assembly code in shim
3c84c57
Add the ability to specify invariant and format
66cb243
Add codegen for default format
04d7e63
Add culture parameter to element-bind tag helpers
e1f53b4
Add code generation support for culture
8d6e130
Remove handling of pre-directive-attribute cases
e9ac371
General cleanup of bind code
dbf5b80
PR feedback
rynowak bfbb9a7
Fix a bug with ref and declaration phase
rynowak 9ac7cb8
Unconditionally enable content in RCLs (dotnet/aspnetcore-tooling#723)
javiercn d9f35d4
Add support for C# 8 nullable forgiveness operator.
cd8ec7a
Move [Layout]
rynowak c76ac7e
Don't pass Analyzers to Razor declaration compilation Csc task invoca…
810e32f
Update tests to specify public [Parameter]
7aeaa72
Modify tag helper infrastructure to configure case sensitivity (dotne…
ajaybhargavb 53841f9
Make some tweaks to the default content globs (dotnet/aspnetcore-tool…
davidfowl f2f0bed
Support [Parameter] attribute on base class of overridden properties …
ajaybhargavb fde8f98
Reactions to API review changes + Globalisation support (dotnet/aspne…
rynowak b724885
React to Roslyn rename of `NullableContextOptions` to `Nullable`.
d62381d
Update test projects to use latest Roslyn.
8dcf4b3
Ensure compilation references are copied during build for netcoreapp2…
pranavkm 4eb4cef
Limit PreserveCompilationReferences to netcoreapp (<2.x)and net4x pro…
pranavkm de8aa5b
Desktop tests
pranavkm 9b05f24
Fixup desktop tests again
pranavkm 8757c7d
More test
pranavkm 35daeda
React to ElementReference change
rynowak 09b2c7d
Fix weakly-typed component bind (dotnet/aspnetcore-tooling#853)
rynowak d30eb2f
Fix serialization of SourceSpan
c9ed74d
Correctly set UpToDateReloadFileTypes (dotnet/aspnetcore-tooling#858)
pranavkm e189edc
Increase timeout in attempt to fix test flakiness (dotnet/aspnetcore-…
ajaybhargavb 4b6a5b2
Revert "Update test projects to use latest Roslyn."
1345358
Enable Razor integration tests to use repos Roslyn version.
36420ad
Forgive nullability violation in directive syntax helpers.
c1d2914
Require public component parameters and remove private metadata worka…
5ea6ba4
Update Roslyn dependencies to align with SDK and VS.
ccf5625
Add support for non-numeric CSharpLanguageVersions.
6ad8b96
Don't fail the build on warnings (dotnet/aspnetcore-tooling#922)
ajaybhargavb 9d594e4
Make launchSettings.json a content item that does not get copied to b…
pranavkm e2d476c
Associate C# version with each Razor extension version.
a202e6c
Update
pranavkm f31e951
Fixup test
pranavkm 7312e7c
Move RenderTreeBuilder to another castle
rynowak 2699268
Prevent StackOverflows when assemblies have recursive references (dot…
pranavkm 56a440e
Make launchSettings.json a content item that does not get copied to b…
pranavkm 88a002a
Enable Component parameter delegates to not require @() at design time.
7fc5972
Fix @inject intellisense (dotnet/aspnetcore-tooling#949)
ajaybhargavb 2abbff5
Don't coalesce <option> tag in ComponentMarkupBlockPass
ajaybhargavb 7e8807a
Print warning when reference assembly is not found (dotnet/aspnetcore…
ajaybhargavb 32196f8
Use globally qualified type name when generating TypeInference (dotne…
pranavkm 80d6dfe
Give "builder" a less discoverable name
pranavkm 2317fc9
Fixup tests
pranavkm 70268e7
[Blazor][Fixes dotnet/aspnetcore-tooling#12933] Remove the need for a…
javiercn 8d23c27
[automated] Merge branch 'release/3.0' => 'master' (dotnet/aspnetcore…
dotnet-maestro-bot 778246c
Add tooling support for TypeScript files to RazorSDK (dotnet/aspnetco…
pranavkm 91c0b06
Merge pull request dotnet/aspnetcore-tooling#972 from dotnet-maestro-…
781743f
[release/3.0] Update dependencies from aspnet/Extensions (dotnet/aspn…
dotnet-maestro[bot] 248326e
Merge branch 'master' into merge/release/3.0-to-master\n\nCommit migr…
pranavkm 9584c7e
Revert "Fix a bug with ref and declaration phase"
f3536ca
Revert "Fix: dotnet/aspnetcore-tooling#11197 automatic backing-field …
c32e2a5
Set LangVersion the same way as roslyn (dotnet/aspnetcore-tooling#978)
ajaybhargavb 2873952
Set LangVersion the same way as roslyn (dotnet/aspnetcore-tooling#979)
ajaybhargavb f757fc2
[master] Update dependencies from aspnet/Extensions (dotnet/aspnetcor…
dotnet-maestro[bot] 56b51f2
Merge branch 'release/3.0' => 'master' (dotnet/aspnetcore-tooling#977)
dougbu e18cc9a
Pass views assembly to linker
nguerrera 15cd2af
Merge branch 'master' into merge/release/3.0-to-master\n\nCommit migr…
wtgodbe cb35a0a
Reaction to API review changes
ad0cf9c
Merge pull request dotnet/aspnetcore-tooling#974 from nguerrera/link-…
Pilchie 5f7c8d9
Apply fix for NuGet warning
dd6faf6
Merge branch 'master' into merge/release/3.0-to-master\n\nCommit migr…
wtgodbe d5c2d17
Merge pull request dotnet/aspnetcore-tooling#983 from aspnet/johluo/sdk
ce19e27
Retarget to netcoreapp5.0 (dotnet/aspnetcore-tooling#996)
pranavkm bfc93b0
Merge pull request dotnet/aspnetcore-tooling#995 from dotnet-maestro-…
wtgodbe 3d19bec
Merge branch 'master' into merge/release/3.0-to-master\n\nCommit migr…
wtgodbe d18498b
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
dougbu 16e93af
Merge pull request dotnet/aspnetcore-tooling#1102 from dotnet-maestro…
4a2e719
Merge pull request dotnet/aspnetcore-tooling#1112 from dotnet-maestro…
61726ae
Restore test projects prior to running SDK tests (dotnet/aspnetcore-t…
ajaybhargavb a163dbe
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
dougbu 1606d9b
Support netcoreapp3.1 TFM (dotnet/aspnetcore-tooling#1122)
901f8aa
[release/3.0] Update dependencies from aspnet/Extensions (dotnet/aspn…
dotnet-maestro[bot] 51ec276
Merge branch 'release/3.1' into merge/release/3.0-to-release/3.1\n\nC…
dougbu a2081d5
Fix razor tool assembly path (dotnet/aspnetcore-tooling#1138)
19b84ed
Merge branch 'release/3.1'
bcd542a
[Infrastructure] Install procdump and capture dumps on build hangs (d…
javiercn 8d08817
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
dougbu dfbb36e
[Infrastructure] Fix invalid variable names
javiercn 228f8f8
Merge pull request dotnet/aspnetcore-tooling#1154 from dotnet-maestro…
javiercn 66f2aac
Integrate Razor LanguageServer (without plugin) into src/Razor.
5bb36d8
Integrate Razor VSCode extension functional tests into src/Razor.
d0d09a2
Merge branch 'nimullen/13494.prereq' into release/3.1
31dbdae
Merge branch 'release/3.1'
fd7b5b6
Switch to embedded PackageIcon
wtgodbe bc9f13b
Merge branches
wtgodbe 5ac5622
Fixup build errors
pranavkm b553f8a
Remove empty lines
pranavkm f6c5aa7
Capture process dumps for child dotnet processes (dotnet/aspnetcore-t…
javiercn b30d6fd
Capture process dumps for child dotnet processes (dotnet/aspnetcore-t…
dotnet-maestro-bot c05fca5
Remove 1.x tests (dotnet/aspnetcore-tooling#1169)
ajaybhargavb 21ba5d0
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
dougbu b8575a5
Merge branch 'release/3.1' into merge/release/3.0-to-release/3.1\n\nC…
wtgodbe eda9503
RazorSDK doesn't overwrite ErrorLog
ryanbrandenburg 287b183
Responding to Pranav's feedback
ryanbrandenburg 39d8e32
Fix misc attribute content sometimes getting ignored (dotnet/aspnetco…
ajaybhargavb 3dcc779
Prefer child content over a matching component (dotnet/aspnetcore-too…
ajaybhargavb 5acc0ae
Add Blazor partial class support in Visual Studio. (dotnet/aspnetcore…
0d5d6e7
Update baselines to unbreak tests (dotnet/aspnetcore-tooling#1184)
ajaybhargavb 1e9c0f0
Add Blazor partial class support in Visual Studio. (dotnet/aspnetcore…
ef8830f
Update baselines to unbreak tests (dotnet/aspnetcore-tooling#1184)
ajaybhargavb 4c959bc
Merge branch 'release/3.1-preview1' => 'release/3.1' (dotnet/aspnetco…
dougbu 1d78957
Embedded resource convention workaround
wtgodbe 7a61205
Add workaround to one more project
wtgodbe 3ce7953
One more missed convention location
wtgodbe 371f2c2
Switch to embedded package icon
wtgodbe 418716e
Merge pull request dotnet/aspnetcore-tooling#1194 from dotnet-maestro…
wtgodbe f19dc08
Fix dotnet/aspnetcore-tooling#10498 - void elements with directive at…
rynowak 777c715
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
dougbu dcc4084
Merge branch 'release/3.1' into merge/release/3.0-to-release/3.1\n\nC…
rynowak 32c2a80
Merge pull request dotnet/aspnetcore-tooling#1213 from dotnet-maestro…
rynowak 73877e9
Allow expressions with @bind:event
rynowak 19c5938
Merge pull request dotnet/aspnetcore-tooling#1216 from dotnet-maestro…
rynowak 4281704
Pass through the correct LangVersion to csc
ajaybhargavb abef940
Merge pull request dotnet/aspnetcore-tooling#1221 from dotnet-maestro…
ajaybhargavb 0844f61
Merge branch 'release/3.1' => 'master' (dotnet/aspnetcore-tooling#1219)
dougbu 49f8ae2
Add support for using a 3.0 SDK on VS 16.4.
82e62cb
Add a flag to prevent config, json files from being copied to the bui…
pranavkm 163c09f
Add support for partial component class editing -> refresh components.
046e3d3
Merge branch 'release/3.1' => 'master' (dotnet/aspnetcore-tooling#1242)
dougbu 2adf261
Merge branch 'release/3.1' => 'master' (dotnet/aspnetcore-tooling#1247)
dougbu 5badd94
Add support for PreventDefault and StopPropagation in event handlers
ajaybhargavb 7f126d5
Addressed minor comments
ajaybhargavb 054c1c5
Retarget rzc.dll to netcoreapp3.0 (dotnet/aspnetcore-tooling#1253)
pranavkm f998cdc
Updated PR with merge conflict resolution changes.
468294a
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
dougbu 18457dd
[release/3.1] Update dependencies from dotnet/arcade (dotnet/aspnetco…
dotnet-maestro[bot] 739f722
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
pranavkm e2dc96c
Fix runtime preventDefault / stopPropagation break.
668e7b3
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
BrennanConroy 7f36d6e
Associate inputs and outputs for .Views dll with a set in FastUpToDat…
pranavkm 6d0088d
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
BrennanConroy db9b852
Go to definition (dotnet/aspnetcore-tooling#1313)
ryanbrandenburg 075c911
Razor GoToImplementation
ryanbrandenburg d5bf4f3
PR feedback
ryanbrandenburg da085ad
[release/3.1] Update dependencies from aspnet/Extensions (dotnet/aspn…
dotnet-maestro[bot] fefb8a5
Rename support in VS Code and other fixes (dotnet/aspnetcore-tooling#…
ajaybhargavb 6942c1c
Switch to Arcade model for PackageIcon (dotnet/aspnetcore-tooling#1325)
wtgodbe 9328e47
Merge branch 'release/3.1' into merge/release/3.0-to-release/3.1\n\nC…
wtgodbe c5fce0f
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
wtgodbe 6ec0c44
Load the netcoreapp3.1 compiled task when running in Core MSBuild
pranavkm 0c907a8
[Static web assets][Fixes #AspNetCore/17079] PublishSingleFile result…
javiercn 3ff767b
[StaticWebAssets][Fixes #AspNetCore/17426] Publish no build doesn't c…
javiercn 5413236
[StaticWebAssets] Updates manifest generation to allow multiple content
javiercn 91efa93
TagHelper QuickInfo (dotnet/aspnetcore-tooling#1443)
ryanbrandenburg 52b9fd8
Update links for repo moves/renames (dotnet/aspnetcore-tooling#1474)
Pilchie 8ea0f36
Remove Test variant Newtonsoft.Json.
631578f
Merge pull request dotnet/aspnetcore-tooling#1394 from dotnet/prkrish…
mkArtakMSFT c2cfbc8
Merge pull request dotnet/aspnetcore-tooling#1442 from dotnet/javierc…
mkArtakMSFT c0bf414
Merge pull request dotnet/aspnetcore-tooling#1383 from dotnet/javierc…
mkArtakMSFT 97c847b
Merge branch 'release/3.1'
jkotalik 18830cb
Update BuildIntrospectionTest.cs\n\nCommit migrated from https://gith…
jkotalik ae7d4ac
Merge branch 'merge/release/3.1-to-master' of https://github.com/dotn…
rynowak 427ec8a
Rely on regular restores for RID-specific package restores (dotnet/as…
pranavkm 4520c64
[release/3.1] Update dependencies from dotnet/extensions (dotnet/aspn…
dotnet-maestro[bot] 3ce497f
Avoid restoring RID specific packs that don't exist.
pranavkm 61cd85b
Merge pull request dotnet/aspnetcore-tooling#1490 from dotnet-maestro…
pranavkm 9cf7425
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
a30ed5c
Update links for repo moves (dotnet/aspnetcore-tooling#1531)
Pilchie ef41514
Skip Publish_CopiesStaticWebAssetsToDestinationFolder_PublishSingleFi…
3dd1427
Skip Publish_NoBuild_CopiesStaticWebAssetsToDestinationFolder.
07fcf46
Supply the `PropertyName` for Context TagHelper results. (dotnet/asp…
ryanbrandenburg a32887a
Sync client settings with LSP server (dotnet/aspnetcore-tooling#1549)
ajaybhargavb 718a130
Fix # in FilePath (dotnet/aspnetcore-tooling#1553)
ryanbrandenburg 2be3171
Upgrade roslyn deps to 3.4.0 (dotnet/aspnetcore-tooling#1564)
ajaybhargavb e4fb1d4
Revert "Remove 1.x tests (dotnet/aspnetcore-tooling#1169)"
ajaybhargavb ca63634
unskip test
ajaybhargavb 3bf1694
Merge branch 'release/3.1'
ajaybhargavb f1ccf85
LSP Razor formatting for Razor code block directives (dotnet/aspnetco…
ajaybhargavb 5565519
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
dougbu b84fc9b
Generate pure HTML document as part of Razor code generation (dotnet/…
ajaybhargavb d41276b
Publish generated HTML in the client (dotnet/aspnetcore-tooling#1633)
ajaybhargavb b8cd714
Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migr…
b89d98d
Split Razor Language Server into library and executable.
d69938f
Initialize LSP documents earlier.
26c5807
<text> Tag IntelliSense Support (dotnet/aspnetcore-tooling#1675)
TanayParikh 926bbfa
Update Roslyn tooling versions.
36c2448
Serialize project state from VS to project.razor.json (dotnet/aspnetc…
ryanbrandenburg 1af2060
[Fixes dotnet/aspnetcore-tooling#17233 dotnet/aspnetcore-tooling#1854…
javiercn 7eca4ab
[Static web assets] Use prebuilt packages in tests
javiercn 069b409
Fix perf issue in LineTrackingStringbuffer.ScanLines.
ToddGrun c027fcf
Missed a minor optimization as I wasn't using a parameter for the bin…
ToddGrun ed7338c
Remove RazorDeveloperTools because they were infrequently used and ca…
b0d819f
Several changes targeted to improving perf of RazorSyntaxTree.Parse (…
ToddGrun f701a18
[master] Update dependencies from dotnet/arcade dotnet/runtime (dotne…
dotnet-maestro[bot] d1e7d8e
Improve HtmlTokenizer.AtToken performance. (dotnet/aspnetcore-tooling…
ToddGrun 485924e
Improve Annotation and SpanContext performance. (dotnet/aspnetcore-to…
ToddGrun a70de6b
Small perf improvement in TokenizerBackedParser.Accept and ReadWhile.…
ToddGrun 016fd1e
Improve CSharpLanguageCharacteristics.MapKeyword performance (dotnet/…
ToddGrun d782a06
Decrease allocations from using method groups (dotnet/aspnetcore-tool…
ToddGrun 323b4ee
Merge pull request dotnet/aspnetcore-tooling#1885 from captainsafia/s…
captainsafia c565c2a
Merge branch 'master' of ..\AspNetCore-Tooling\ into johluo/tooling-s…
50f3a16
aspnetcore-tooling migration fixups
50d914f
Merge branch 'master' into johluo/tooling-consolidation-fixup
5602686
Merge fixup
0d2eb28
Merge branch 'master' into johluo/tooling-consolidation-fixup
3353641
Fix race in build
5a64926
Remove CPD
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch