Skip to content

Avoid trying to fix the trusted root certificates #21599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2020
Merged

Avoid trying to fix the trusted root certificates #21599

merged 1 commit into from
May 8, 2020

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented May 7, 2020

  • The tool fails when a trusted certificate has already been installed.
  • We were trying to fix the key for the localhost certificates on the system keychain (which don't have a key)
  • This fix filters the certificates to fix to those found in the current user personal store (login keychain).
  • I verified running multiple combinations of dotnet dev-certs with --clean and --trust.
    • Unfortunately we can't have automation for these cases as trying to access the key requires user interaction.
    • We will be expanding the set of CTI cases to cover this scenarios.

@javiercn javiercn marked this pull request as ready for review May 7, 2020 23:00
@javiercn javiercn requested a review from pranavkm May 7, 2020 23:00
@mkArtakMSFT mkArtakMSFT added this to the 5.0.0-preview4 milestone May 7, 2020
@mkArtakMSFT mkArtakMSFT merged commit cdfa43b into release/5.0-preview4 May 8, 2020
@mkArtakMSFT mkArtakMSFT deleted the javiercn/trust-fix branch May 8, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0-preview4
Development

Successfully merging this pull request may close these issues.
3 participants
@javiercn @pranavkm @mkArtakMSFT