-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Capture dump of hanging test process in Helix #21659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
{ | ||
// Helix timeout is 30 minutes right now | ||
var cts = new CancellationTokenSource(TimeSpan.FromMinutes(25)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This is configurable from our side isn't it? should we pass this in as an option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this seems too long no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this seems too long no?
I saw IIS test runs taking 19 minutes
set $aspnetref=%9 | ||
REM Batch only supports up to 9 arguments using the %# syntax, need to shift to get more | ||
shift | ||
set $helixTimeout=%9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is starting to get a bit out of control, should we consider a better way to flow things from our build to the helix test runner, idk what config file, environment variables? Just seems like we are going to constantly keep adding arguments over time otherwise... not something we have to do as part of this PR, but worth thinking about now maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
Stealing David's work on Helix until it goes in Helix