Skip to content

Capture dump of hanging test process in Helix #21659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 12, 2020
Merged

Conversation

BrennanConroy
Copy link
Member

Stealing David's work on Helix until it goes in Helix

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 9, 2020
@BrennanConroy BrennanConroy marked this pull request as ready for review May 11, 2020 17:41
@BrennanConroy BrennanConroy requested review from HaoK and davidfowl May 11, 2020 17:41
{
// Helix timeout is 30 minutes right now
var cts = new CancellationTokenSource(TimeSpan.FromMinutes(25));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This is configurable from our side isn't it? should we pass this in as an option?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this seems too long no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this seems too long no?

I saw IIS test runs taking 19 minutes

set $aspnetref=%9
REM Batch only supports up to 9 arguments using the %# syntax, need to shift to get more
shift
set $helixTimeout=%9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting to get a bit out of control, should we consider a better way to flow things from our build to the helix test runner, idk what config file, environment variables? Just seems like we are going to constantly keep adding arguments over time otherwise... not something we have to do as part of this PR, but worth thinking about now maybe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@BrennanConroy BrennanConroy added this to the 5.0.0-preview6 milestone May 12, 2020
@BrennanConroy BrennanConroy merged commit f56c61b into master May 12, 2020
@BrennanConroy BrennanConroy deleted the brecon/hang branch May 12, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants