[release/5.0-preview5] Update dependencies from dotnet/aspnetcore-tooling #21710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…build 20200511.4 - Microsoft.AspNetCore.Mvc.Razor.Extensions: 5.0.0-preview.5.20258.1 -> 5.0.0-preview.5.20261.4 - Microsoft.AspNetCore.Razor.Language: 5.0.0-preview.5.20258.1 -> 5.0.0-preview.5.20261.4 - Microsoft.CodeAnalysis.Razor: 5.0.0-preview.5.20258.1 -> 5.0.0-preview.5.20261.4 - Microsoft.NET.Sdk.Razor: 5.0.0-preview.5.20258.1 -> 5.0.0-preview.5.20261.4 Dependency coherency updates - Microsoft.Extensions.Caching.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Caching.Memory: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Binder: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.CommandLine: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.EnvironmentVariables: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.FileExtensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Ini: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Json: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.UserSecrets: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Xml: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.DependencyInjection.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.DependencyInjection: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Composite: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Physical: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileSystemGlobbing: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Hosting.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Hosting: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Http: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Configuration: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Console: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Debug: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.EventSource: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.EventLog: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.TraceSource: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Options.ConfigurationExtensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Options.DataAnnotations: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Options: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Primitives: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Internal.Transport: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Win32.Registry: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Win32.SystemEvents: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.ComponentModel.Annotations: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Diagnostics.EventLog: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Drawing.Common: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.IO.Pipelines: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Net.Http.WinHttpHandler: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Net.WebSockets.WebSocketProtocol: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Reflection.Metadata: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Runtime.CompilerServices.Unsafe: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Security.Cryptography.Cng: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Security.Cryptography.Pkcs: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Security.Cryptography.Xml: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Security.Permissions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Security.Principal.Windows: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.ServiceProcess.ServiceController: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Text.Encodings.Web: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Text.Json: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Threading.Channels: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - System.Windows.Extensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.DependencyModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.NETCore.App.Ref: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.NETCore.App.Runtime.win-x64: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.NETCore.App.Internal: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.NETCore.Platforms: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Net.Compilers.Toolset: 3.7.0-1.20254.1 -> 3.7.0-2.20259.1 (parent: Microsoft.AspNetCore.Razor.Language)
ghost
added
area-infrastructure
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
Yes, the ideal would be to port the work from #21630 into this branch. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
- do not merge into 'master' branch
|
@HaoK and @JunTaoLuo two of the targeting pack tests are consistently failing in the Helix jobs. Could you have a look at what's going on? Errors include |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
These failures look reasonable, the tests seem to expect that these assemblies should have reference assembly attributes, did these extensions dlls change recently? |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
I'm taking a look at the dotnet/runtime assets. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
Ah I see, this Extensions.Internal.Transport package is targeting net5.0 tfm now and our logic was having trouble recognizing that. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
I think I fixed it, I'm not sure what the gradle error is about though |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
Reran the failed job because the errors look transient: |
Auto-Merge StatusThis pull request will be merged because the following merge policies have succeeded.
|
dotnet-maestro
bot
deleted the
darc-release/5.0-preview5-54e8bdb0-8820-47d7-a460-bdde9f165803
branch
dougbu
added a commit
that referenced
this pull request
May 30, 2020
* Make `dotnet msbuild` the default on Windows too
- add step using desktop `msbuild` when native builds may be involved
- `-All` (without `-NoBuildNative`), `-BuildNative` or `-BuildInstallers` run this step
- but `-ForceCoreMsbuild` unconditionally skips this step
nits:
- add binary log for RepoTasks build if `$BinaryLog` (echoes the `dotnet msbuild` command)
- add blank lines between build steps
* Enable building managed projects depending on native assets
- splitting native builds out confuses these projects
- use `$(BuildNative)` less, only to control actual building (not bundling)
- build both native platforms in one `msbuild` invocation
* Adjust generation scripts to explicitly choose the MSBuild engine
- ensure native assets are included in GenerateReferenceAssemblies.ps1 build
- clean up the global state that tools.ps1 corrupts
* Revert move to VS2019.Pre queues
This reverts part of commit b67d161
- was "[release/5.0-preview5] Update dependencies from dotnet/aspnetcore-tooling (#21710)"
* Revert "!temporary! Require `msbuild` from VS2019 16.6"
- this reverts commit 58cf230
* Reduce build duplication in pipelines
- build native assets and repo tasks once per CI job
- only cleanup framework references after packing managed projects
nits:
- wrap a few long lines
- remove extra `-forceCoreMsbuild` options in SiteExtensions' build.cmd
* Fix Helix jobs
- restore.cmd doesn't work well with `-projects`; script unconditionally adds `-all`
* !fixup! Reduce duplications further
- missed a couple of places `-noBuildRepoTasks` helps
* Cleanup: Remove a few dangling binary logs
* !fixup! Correct typos in generation scripts
* !fixup! Another typo in the generation scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/aspnetcore-tooling