-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Revert bad changes from merge forward PR #21848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Narrow this two just eng/Version*.* and you're done.
I'm really starting to hate desktop |
If the Helix build succeeds, I'm going to ignore that OOM. But, I'm going to let the current build finish. (FYI Helix jobs don't get canceled when the pipeline that submitted them is canceled. So, canceling a build doesn't clean up as much as you'd like.) |
A fix we made to src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj in d99e7fe broke this build. Suggest we just leave things alone since #21630 is validating 🆗 and we can undo the src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj change only after that goes in. #21630 also overwrites some of the versions in this PR and the next dependency update will make everything coherent again. That is, if I'm correct, let's get #21630 in and close this PR. |
I'm a little uncertain about the action plan then. So what you are saying is:
Is that correct? |
@jkotalik yes you've got the plan down. #21630 is in (hurray 🚀) and the last bullet can happen whenever
/fyi that change worked around an inconsistency between the incoming packages from dotnet/runtime that goes away now that we're targeting |
Fixes #21630 (comment)
cc @dougbu