Skip to content

Use bogus phone tokens for failure message check to avoid collisions #21853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2020
Merged

Use bogus phone tokens for failure message check to avoid collisions #21853

merged 1 commit into from
May 15, 2020

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented May 14, 2020

The errors always seem to be with the failure tokens still working, so use illegal tokens that should never validate

@ghost ghost added the area-identity Includes: Identity and providers label May 14, 2020
@HaoK HaoK linked an issue May 14, 2020 that may be closed by this pull request
Make identity tests more reliable when tokens collide #21851
Closed
@HaoK HaoK marked this pull request as ready for review May 15, 2020 18:28
@HaoK HaoK requested a review from ajcvickers May 15, 2020 18:28
@HaoK HaoK merged commit 5508e76 into master May 15, 2020
@HaoK HaoK deleted the haok/phone branch May 15, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
area-identity Includes: Identity and providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make identity tests more reliable when tokens collide
2 participants
@HaoK @ajcvickers