Fixup JS #21922
Merged
Fixup JS #21922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pranavkm
commented
May 17, 2020
| @@ -13,8 +13,8 @@ export const internalFunctions = { | |||
| listenForNavigationEvents, | |||
| enableNavigationInterception, | |||
| navigateTo, | |||
| getBaseURI: () => BINDING.js_string_to_mono_string(document.baseURI), | |||
| getLocationHref: () => BINDING.js_string_to_mono_string(location.href), | |||
| getBaseURI: () => document.baseURI, | |||
There was a problem hiding this comment.
This file is common to the Server and WebAssembly, so we cannot do this here. Moving this to Boot.WebAssembly. Let me know if there's a better way to do this.
There was a problem hiding this comment.
Why didn't we use document.baseURI in the past? Doesn't this change any expectation wherever this is used?
There was a problem hiding this comment.
We did use document.baseURI in the past - see the old line 16.
| @@ -2,7 +2,7 @@ import '../src/GlobalExports'; | |||
| import { UserSpecifiedDisplay } from '../src/Platform/Circuits/UserSpecifiedDisplay'; | |||
| import { DefaultReconnectionHandler } from '../src/Platform/Circuits/DefaultReconnectionHandler'; | |||
| import { NullLogger} from '../src/Platform/Logging/Loggers'; | |||
| import { resolveOptions, ReconnectionOptions } from "../src/Platform/Circuits/BlazorOptions"; | |||
| import { resolveOptions, ReconnectionOptions } from "../src/Platform/Circuits/CircuitStartOptions"; | |||
There was a problem hiding this comment.
Old rename that had left this test broken
SteveSandersonMS
approved these changes
May 18, 2020
There was a problem hiding this comment.
I made a suggestion, but this is straightforward enough just to approve. I'm sure @pranavkm can make a sensible choice about how to tidy away the final details :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.