-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Fix logging config and output redirection in DebugProxy #22157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
In the case of a hosted project, should the config go in the client project or the server one? I guess it’s the server because there could be any number of client projects but only one instance of the debugging middleware. Is that right?
Oh also, is it worth patching MonoProxy.cs to enable output for verbose log entries? We can get this fixed in the upstream repo (Mono) later but that may take longer than doing it ourselves in the aspnet repo. |
Yes, for a server project it would go under the root of
Done. I went ahead and enabled protocol logs as well. |
@pranavkm there seems to be some
Was there an intentional change to break this? |
Internal Server Error sounds like an issue with GitHub. We also haven't been using helix in the 3.1 / blazor-wasm branch. |
@pranavkm @mkArtakMSFT I think we can sensibly ignore this one. It showed up on Friday when GitHub was having a service degradation. That build doesn't seem to be a part of the checks that we do on blazor-wasm. I think it was incorrectly added while GitHub was being wonky and is stuck in that state now. Are folks cool with merging this? |
Sure, let's get this in. |
* Fix logging config and output redirection in DebugProxy * Log all messages from DebugProxy
Here's are examples of output from the DebugProxy when running the
StandaloneApp
with the followingblazor-debugproxysettings.json
in the project root.Addresses #22134