Capture gRPC interop test client output #22163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
changed the title
dougbu
approved these changes
May 22, 2020
| @@ -15,9 +16,13 @@ public class ClientProcess : IDisposable | |||
| private readonly Process _process; | |||
| private readonly ProcessEx _processEx; | |||
| private readonly TaskCompletionSource<object> _startTcs; | |||
| private readonly StringBuilder _output; | |||
There was a problem hiding this comment.
Suggest cleaning this object up in Dispose()
There was a problem hiding this comment.
It will get GCed with ClientProcess so I'm not worried about it
| { | ||
| lock (_outputLock) | ||
| { | ||
| _output.AppendLine(data); |
There was a problem hiding this comment.
Should error and regular output be distinguished in the buffer e.g. with an ERROR: prefix?
There was a problem hiding this comment.
The only error output would be if an exception is thrown, and it should be obvious. Will change in the future if it is confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write client output when an error occurs (or timeout) to help debugging
re: #22145 & #22102