Replace usages of Assembly.CodeBase with Assembly.Location #22258
Conversation
|
We should also handle the location being empty |
pranavkm
force-pushed
the
prkrishn/assemblylocation
branch
from
04d05e0 to
a5065fc
Compare
MVC already did this. I updated the StaticAssets code to manage it. The remainder of the changes are in test code. |
| @@ -66,7 +66,7 @@ public static IReadOnlyList<Assembly> GetRelatedAssemblies(Assembly assembly, bo | |||
|
|
|||
| // MVC will specifically look for related parts in the same physical directory as the assembly. | |||
| // No-op if the assembly does not have a location. | |||
| if (assembly.IsDynamic || string.IsNullOrEmpty(assembly.CodeBase)) | |||
| if (assembly.IsDynamic || string.IsNullOrEmpty(assembly.Location)) | |||
There was a problem hiding this comment.
Is this right? Will this not fail with the new publish single file work?
There was a problem hiding this comment.
I'm not entirely sure how that works, but we should tackle that separately. This doesn't make the code more incorrect than before.
There was a problem hiding this comment.
That's fair, can we file an issue to track that work?
There was a problem hiding this comment.
We had issues where users had controllers in dynamically generated assemblies.
There was a problem hiding this comment.
But what does that check have to do with anything here?
There was a problem hiding this comment.
- The way you add the controller assembly is by registering it as an application part.
- MVC will attempt to look up related parts by using the assembly's location.
- Accessing the location property on a dynamically generated assembly throws.
If the stars align, MVC will throw. Does that help?
Fixes #14827