Skip to content

Delete StackTraceHelper code that won't fire #22419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Conversation

hueifeng
Copy link
Contributor

@hueifeng hueifeng commented Jun 1, 2020

These changes can be clearly seen that the corresponding processing has been done above the code block, so it will not be executed in every deleted code block.

These changes can be clearly seen that the corresponding processing has been done above the code block, so it will not be executed in every deleted code block.
@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 1, 2020
@pranavkm
Copy link
Contributor

pranavkm commented Jun 3, 2020

Build errors on this one. If you're eliminating nulls, could you annotate this file with #nullable enable? This should give us more confidence that there aren't other nullability issues lurking here.

@hueifeng
Copy link
Contributor Author

hueifeng commented Jun 3, 2020

@pranavkm I think it is ok, do I need to modify this file to add #nullable enable?
Or do I need to modify our library to be empty <Nullable>enable</Nullable>?

@pranavkm
Copy link
Contributor

pranavkm commented Jun 3, 2020

Just the one file since it's shared.

@hueifeng
Copy link
Contributor Author

hueifeng commented Jun 3, 2020

@padmasrid I submitted the changes.

@pranavkm pranavkm merged commit 544afc0 into dotnet:master Jun 3, 2020
@pranavkm pranavkm added this to the 5.0.0-preview7 milestone Jun 3, 2020
@BrennanConroy BrennanConroy mentioned this pull request Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants