-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Don't explicitly import Arcade SDK in AfterSigning.targets #22429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The internal build produced the checksum files without the warnings. The issue was that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might work but it's not clear why AfterSigning.targets uses the Arcade SDK at all. Isn't it imported from an Arcade SDK project. We don't do anything similar in Publishing.props or Signing.props for example.
eng/AfterSigning.targets
Outdated
@@ -29,5 +27,5 @@ | |||
</Target> | |||
|
|||
<Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" Condition="'$(GenerateChecksums)' == 'true'" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this <Import/>
both still needed and 🆗❔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checksums weren't produced without it, because SDK.targets imports https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/tools/Imports.targets, which imports GenerateChecksums.targets
. AfterSigning.targets
doesn't import that. Presumably publishing/signing.props don't need to import anything because they don't use custom tasks like GenerateChecksums
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to directly import a specific .targets
file from the Arcade SDK (@riarenas @JohnTortugo @chcosta)? If so that'd probably be best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @riarenas @JohnTortugo @chcosta + @mmitche
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also @jcagme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if there's a way to import a specific targets file from an msbuild sdk
@rainersigwald confirmed we can't import a specific .targets file without calculating the path to the file on-disk, so I'll just merge this as-is |
Attempts to resolve #22244
Internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=667109&view=results