Skip to content

Log message when connection reaches maximum concurrent streams #22452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2020
Merged

Log message when connection reaches maximum concurrent streams #22452

merged 5 commits into from
Jun 2, 2020

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jun 2, 2020

Fixes #20930

@ghost ghost added the area-servers label Jun 2, 2020
halter73
halter73 reviewed Jun 2, 2020
View reviewed changes
@JamesNK
Copy link
Member Author

JamesNK commented Jun 2, 2020 •
edited
Loading

Http2ReachedMaxConcurrentStreams or Http2MaxConcurrentStreamsReached?

Bikeshedding: GO

Edit: Http2MaxConcurrentStreamsReached follows the existing standard of event names more closely. Updated PR to use it.

Tratcher
Tratcher reviewed Jun 2, 2020
View reviewed changes
@JamesNK JamesNK added this to the 5.0.0-preview7 milestone Jun 2, 2020
@JamesNK JamesNK merged commit 8009350 into master Jun 2, 2020
@JamesNK JamesNK deleted the jamesnk/maxconcurrentstreams-log branch June 2, 2020 22:11
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher left review comments

@halter73 halter73 halter73 approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
5.0.0-preview7
Development

Successfully merging this pull request may close these issues.

HTTP2: Log a debug message when connection reaches maximum active stream limit
4 participants
@JamesNK @halter73 @Tratcher @amcasey