Set the correct tfm in Wasm template.json #22681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
mkArtakMSFT
approved these changes
Jun 8, 2020
|
Aren't we still targeting |
|
This is for the ASP.NET Core hosted template. The host is targeting net5 and why in blazor-wasm it said netcoreapp3.1. |
|
👍 Thanks for the explanation @pranavkm |
|
This was approved by Tactics |
|
@mkArtakMSFT Good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Blazor WebAssembly templates have incorrect metadata in the template.json
Customer Impact
If a preview6 SDK is installed, Blazor WebAssembly no longer appears in VS. Installing via CLI also fails. This is particularly problematic since the 3.2 WASM templates are also unavailable to be installed once the preview6 is installed.
Regression?
The WASM templates are new to 5.0
Risk
Low. The template.json config accurately represents the actual contents of the template.