Johluo/targeting pack tests #23045
Merged
Johluo/targeting pack tests #23045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 15, 2020 02:05
Add test for assembly versions
ghost
added
the
feature-platform
wtgodbe
reviewed
Jun 17, 2020
wtgodbe
approved these changes
Jun 17, 2020
dougbu
approved these changes
Jun 17, 2020
|
I checked our tests in the shared framework and the targeting pack and it seems we never use any hardcoded values for expected assemblies. Is that something we want to add? |
|
I think it would be good to have a hardcoded baseline that we test against so that we notice when something is added/removed from the targeting pack. |
JunTaoLuo
pushed a commit
that referenced
this pull request
Jun 18, 2020
* Add test for assembly versions * Add test for framework list * Add some hardcoded lists for sharedfx and targeting pack content
JunTaoLuo
pushed a commit
that referenced
this pull request
Jul 15, 2020
* Add sharedfx and targeting pack tests (#23045) * Add test for assembly versions * Add test for framework list * Add some hardcoded lists for sharedfx and targeting pack content * Fix failing tests * Fix targeting pack tests * Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19151 and #14832. Note that I'm making the changes to 5.0 first. I'll port to 3.1 when it's done.