Skip to content

Fix build issues in Blazor WASM template tests #23052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

captainsafia
Copy link
Member

Currently, all the Blazor WASM template tests are failing because they are unable to find tasks in assemblies that do not exist.

F:\workspace\_work\1\s\.dotnet\sdk\5.0.100-preview.6.20266.3\MSBuild.dll -maxcpucount -property:Configuration=Release -target:Publish -verbosity:m /bl .\AspNet.blazorserverindividual.sbmuheoguk4.csproj
  You are using a preview version of .NET. See: https://aka.ms/dotnet-core-preview
F:\workspace\_work\1\s\src\Razor\Microsoft.NET.Sdk.Razor\src\build\netstandard2.0\Microsoft.NET.Sdk.Razor.MvcApplicationPartsDiscovery.targets(54,5): error MSB4062: The "Microsoft.AspNetCore.Razor.Tasks.FindAssembliesWithReferencesTo" task could not be loaded from the assembly F:\workspace\_work\1\s\src\Razor\Microsoft.NET.Sdk.Razor\src\build\netstandard2.0\..\..\tasks\net5.0\Microsoft.NET.Sdk.Razor.Tasks.dll. Could not load file or assembly 'F:\workspace\_work\1\s\src\Razor\Microsoft.NET.Sdk.Razor\src\tasks\net5.0\Microsoft.NET.Sdk.Razor.Tasks.dll'. The system cannot find the path specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [F:\workspace\_work\1\s\src\ProjectTemplates\BlazorTemplates.Tests\bin\Release\net5.0\TestTemplates\AspNet.blazorserverindividual.sbmuheoguk4\AspNet.blazorserverindividual.sbmuheoguk4.csproj]

This is an attempt to fix this by adding a project reference to the Razor SDK so we ensure the assemblies are built before they are referenced.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 17, 2020
@captainsafia captainsafia added area-blazor Includes: Blazor, Razor Components and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jun 17, 2020
@captainsafia captainsafia force-pushed the safia/blazor-templ-tests branch from 4cbbb74 to a8e9871 Compare June 17, 2020 20:32
@captainsafia
Copy link
Member Author

captainsafia commented Jun 17, 2020

Woop - quarantined tests don't run on PR builds so we'll have to unquarantine to verify this is working.

EDIT: Looks like only some of the test are quarantined so we are good to validate if this works.

@captainsafia captainsafia merged commit 7a82a48 into master Jun 17, 2020
@captainsafia captainsafia deleted the safia/blazor-templ-tests branch June 17, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants