Render aria-invalid if the state is invalid #23131
Conversation
ghost
added
the
I'd recommend that, if the |
|
Is it possible also to add an E2E test to show that:
It should be possible to do that by extending the existing test cases, for example here (with the code being tested here). Thanks! |
| @@ -25,7 +26,7 @@ public abstract class InputBase<TValue> : ComponentBase, IDisposable | |||
| /// <summary> | |||
| /// Gets or sets a collection of additional attributes that will be applied to the created element. | |||
| /// </summary> | |||
| [Parameter(CaptureUnmatchedValues = true)] public IReadOnlyDictionary<string, object> AdditionalAttributes { get; set; } | |||
| [Parameter(CaptureUnmatchedValues = true)] public Dictionary<string, object> AdditionalAttributes { get; set; } | |||
There was a problem hiding this comment.
Out of interest, is IDictionary also a viable option here?
There was a problem hiding this comment.
Dictionary implements IReadOnlyDictionary and is not a code breaking change, where as if I change this to IDictionary instead, tests where we have something like the following, break. I expect this will also break customer code.
public new IReadOnlyDictionary<string, object> AdditionalAttributes => base.AdditionalAttributes;Let me know if you want me to change this to IDictionary - I am not against it.
|
|
||
| private void SetAdditionalAttributesIfValidationFailed() | ||
| { | ||
| if (!EditContext.GetValidationMessages(FieldIdentifier).Any()) |
There was a problem hiding this comment.
Would it help if we added a IsValid \ HasValidationMessages to EditContext?
There was a problem hiding this comment.
I think it makes sense to add IsValid for sure, and not in this particular case only. I've seen customers in other comments also using this technique to check the validation state.
Co-authored-by: Pranav K <[email protected]>
|
@SteveSandersonMS please let me know if you have any concerns with current state. |
|
@SteveSandersonMS let me know if you want me to change something here. I'm merging this now as the branching will happen tomorrow. |
|
@mkArtakMSFT Looks good - thanks! |
Automatically render
aria-invalidattribute for components derived from theInputBase, when the validation state is invalid.Note: I've made a small breaking change by changing the type of the
AdditionalPropertiesproperty. This was necessary to avoid copying existing values later on.One question I have here, is what will happen if the developer explicitly specifies the
aria-invalid=falsewhen declaring the component?Addresses #14214