Allow extensibility of DefaultAuthorizationService #23143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pranavkm
reviewed
Jun 22, 2020
| @@ -77,7 +77,7 @@ public DefaultAuthorizationService(IAuthorizationPolicyProvider policyProvider, | |||
| /// A flag indicating whether authorization has succeeded. | |||
| /// This value is <value>true</value> when the user fulfills the policy otherwise <value>false</value>. | |||
| /// </returns> | |||
| public async Task<AuthorizationResult> AuthorizeAsync(ClaimsPrincipal user, object? resource, IEnumerable<IAuthorizationRequirement> requirements) | |||
| public virtual async Task<AuthorizationResult> AuthorizeAsync(ClaimsPrincipal user, object? resource, IEnumerable<IAuthorizationRequirement> requirements) | |||
There was a problem hiding this comment.
Is there a reason this couldn't use explicit interface implementation?
There was a problem hiding this comment.
I believe that way you can only replace the methods instead of building upon them?
When allowing to override, a developer can still call the base method from inside the overridden method to reuse the logic and add own behavior.
|
@hansmbakker can you update the ref assembly as well? https://github.com/dotnet/aspnetcore/blob/master/docs/ReferenceAssemblies.md |
When only a small behavior change of the `DefaultAuthorizationService` is wanted, it would be nice if you could override its methods and building upon them rather than having a copy-paste of the class in your codebase. Inside the `override` methods in your inherited class you could call the `base` method to reuse parts of its logic. Please refer to #23094 for the usecase.
|
@HaoK done |
|
|
HaoK
approved these changes
Jul 1, 2020
|
Thanks @hansmbakker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only a small behavior change of the
DefaultAuthorizationServiceis wanted, it would be nice if you could override its methods and building upon them rather than having a copy-paste of the class in your codebase.Inside the
overridemethods in your inherited class you could call thebasemethod to reuse parts of its logic.Please refer to #23094 for the usecase & details.
Addresses #23094