SDK fixes #23317
Merged
SDK fixes #23317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pranavkm
commented
Jun 24, 2020
pranavkm
commented
- Ports Fix up Blazor ILLink Descriptor files #23313 to preview7
- Only include dlls when generating type granular assemblies
- Write server-worker to the obj directory
1. Add the typegranularity file to TrimmerRootDescriptor. 2. Remove the application assembly descriptor file, since the application assembly is passed in as a RootAssembly already.
* Only include dlls when generating type granular assemblies * Write server-worker to the obj directory
ghost
added
the
area-mvc
|
FYI @eerhardt |
javiercn
approved these changes
Jun 24, 2020
eerhardt
reviewed
Jun 24, 2020
| @@ -121,7 +121,7 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <_ServiceWorkerIntermediatePublishFile Include="%(ServiceWorker.IntermediateOutputPath)serviceworkers\%(FileName).publish%(Extension)"> | |||
| <_ServiceWorkerIntermediatePublishFile Include="$(IntermediateOutputPath)serviceworkers\%(FileName).publish%(Extension)"> | |||
There was a problem hiding this comment.
I'm not understanding what is being selected/included here. By removing %(ServiceWorker. where are the items coming from?
There was a problem hiding this comment.
It constructs the path that later gets written to:
It is a bit awkward that the output is the identity, but that's how this target was previously written
eerhardt
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.