Migrate to single sln file + slnf files #23581
Conversation
Pilchie
added
the
area-infrastructure
Pilchie
requested review from
BrennanConroy,
halter73,
jkotalik,
SteveSandersonMS and
Tratcher
as code owners
There was a problem hiding this comment.
This will be ready to go once you change enough *.cs files to get the remaining tests working. Some are likely looking for generated *.sln files but there are a lot of matches for .sln in *.cs files. Worse, a few like the match in src\Razor\Microsoft.AspNetCore.Razor.Language\test\Legacy\BaselineWriter.cs are exercised only when regenerating test baselines
|
Do we need to make an announcement for this (whether internal or external)? I wouldn't be surprised if some people's workflows may be disrupted by this change. |
|
Good idea. I can at least email the team internally. Wonder if there are enough external contributors to make a post in aspnet/announcments, or maybe I just make a pinned issue for a bit? |
|
Can you start by summarizing the impact on developers here? |
|
Any of those options seem fine. Also could update the getting started. |
|
I think there are some tests (server tests, blazor tests, IIS tests) that use the location of the sln to find specific files. I think you'll probably need to update them to slnf or update the test infrastructure to use a better path. |
|
👍 to @jkotalik's suggestion. It'd be nice to point to the documentation on slnf files: https://docs.microsoft.com/en-us/visualstudio/ide/filtered-solutions?view=vs-2019 given slnf is a fairly new (and uncommonly seen-in-the-wild) feature. |
|
Not Blazor nor MVC tests. We do all that through assembly attributes we stamp on the test assembly |
Can we send an email to the team so that we get someone from each team to test their main area in case we missed something? Someone on @mkArtakMSFT team can go ahead and test MVC/Blazor and someone on the Core team can do the same thing for Servers/Signalr. /cc: @Tratcher @jkotalik before we merge. I don't want this PR to be open for long since it'll get stale really quick. |
|
I know @BrennanConroy took a look at the experience before. |
Has anything changed? |
|
Not really - just working on getting it updated for the blazor-wasm merge, and actually fixing tests this time. |
| 3. Can't find a solution that has the projects you care about? Feel free to make a PR to add a new .sln file. | ||
|
|
||
| > :bulb: Pro tip: `dotnet new sln` and `dotnet sln` are one of the easiest ways to create and modify solutions. | ||
| 3. Can't find a solution that has the projects you care about? Feel free to make a PR to add a new .slnf file. |
|
The BuildFromSource description seems adequate, though I'm still wondering how many complaints we'll get about people trying to open the root sln directly. The biggest downside I see to snlfs is the inability for a project to organize its view of the solution. The old slns usually had a Dependencies section to isolate the unrelated projects and allowed for a simpler structure for the relevant items. |
Can we rename it something less inviting like |
|
Meh - I think VS is working on scaling better to solutions like this. I was able to work on the full solution on my desktop for some tasks though the perf definitely wasn't what I'd like. |
|
If there are no other objections, I plan to merge this later this afternoon. |
No description provided.