Skip to content

Add SignIn method without authentication scheme #23604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Jul 2, 2020

Fixes #23325

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 2, 2020
@Kahbazi
Copy link
Member Author

Kahbazi commented Jul 2, 2020

@Tratcher Do I need to have the latest preview version of Visual Studio in order to generate the reference assemblies?

@Tratcher
Copy link
Member

Tratcher commented Jul 2, 2020

@Tratcher Do I need to have the latest preview version of Visual Studio in order to generate the reference assemblies?

Did the docs/ReferenceAssemblies.md instructions not work for you?

The good news is that this manual reference assembly generation process is going away soon. #23403

@Tratcher Tratcher requested a review from HaoK July 2, 2020 14:12
@Kahbazi
Copy link
Member Author

Kahbazi commented Jul 2, 2020

Did the docs/ReferenceAssemblies.md instructions not work for you?

No, it worked a few times in the past, but I usually end up doing them manually.

@javiercn
Copy link
Member

@Kahbazi where are you stuck with the ref assembly generation?

@Kahbazi
Copy link
Member Author

Kahbazi commented Jul 14, 2020

I get error MSB4057: The target "GenerateReferenceSource" does not exist in the project. after running dotnet msbuild /t:GenerateReferenceSource.

If the changes in this PR is ok, I'll update the reference assemblies manually.

@javiercn
Copy link
Member

@Kahbazi let me try fetching your branch and see if I can get it to work or if I see the same issue. If I can get it to work maybe I can figure out the process for pushing a commit on top and we should be good. I'm not sure if I'll have to end-up creating a separate PR with your commit on it to be able to do it, but we can at least figure out the changes and you can apply them manually on top if necessary

@javiercn
Copy link
Member

Here is the patch with the changes, this should at least make it easier to make the changes. 0001-Update-ref-assemblies.txt

Alternatively, what I did was to run .\eng\scripts\GenerateReferenceAssemblies.ps1

@Kahbazi
Copy link
Member Author

Kahbazi commented Jul 14, 2020

@javiercn thanks for the patch. I tried .\eng\scripts\GenerateReferenceAssemblies.ps1 before. It didn't work for me either.

@javiercn javiercn merged commit 9d7c3af into dotnet:master Jul 14, 2020
@javiercn
Copy link
Member

Merged.

@Kahbazi thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent requirement to specify auth scheme
4 participants