[Java] Allow configuration of OkHttpClient.Builder #23822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Jul 10, 2020
...SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/WebSocketTransportTest.java
Outdated
Show resolved
Hide resolved
halter73
reviewed
Jul 10, 2020
...gnalR/clients/java/signalr/src/main/java/com/microsoft/signalr/HttpHubConnectionBuilder.java
Outdated
Show resolved
Hide resolved
|
Any other feedback here? |
halter73
reviewed
Jul 16, 2020
...gnalR/clients/java/signalr/src/main/java/com/microsoft/signalr/HttpHubConnectionBuilder.java
Outdated
Show resolved
Hide resolved
…ignalr/HttpHubConnectionBuilder.java
halter73
reviewed
Jul 16, 2020
src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/DefaultHttpClient.java
Outdated
Show resolved
Hide resolved
halter73
reviewed
Jul 17, 2020
| @@ -36,7 +36,7 @@ public void close() { | |||
| } | |||
| } | |||
|
|
|||
| public DefaultHttpClient(int timeoutInMilliseconds, OkHttpClient client) { | |||
| public DefaultHttpClient(int timeoutInMilliseconds, OkHttpClient client, Action1<OkHttpClient.Builder> configureBuilder) { | |||
There was a problem hiding this comment.
Can we remove the timeoutInMilliseconds parameter then? I don't see anywhere it's passed in with a null client, and with a non-null client it doesn't do anything.
halter73
approved these changes
Jul 20, 2020
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
BrennanConroy
added
the
tell-mode
|
@dotnet/aspnet-build could I get a merge please? I already talked to Kevin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15404
No functional tests in java currently. Manually tested out setting a cert pinner and read timeout on the builder, looks good.
New method on the
HttpHubConnectionBuilderclass.HttpHubConnectionBuilder setHttpClientBuilderCallback(Action1<OkHttpClient.Builder> configureBuilder)