Skip to content

[Helix] Try out the new dotnet test blame functionality #23862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 32 commits into from
Closed

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jul 10, 2020

Add a hanging test to see if dmps work now

@ghost ghost added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Jul 10, 2020
@HaoK HaoK added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform labels Jul 10, 2020
@HaoK
Copy link
Member Author

HaoK commented Jul 10, 2020

cc @davidfowl

@davidfowl
Copy link
Member

@HaoK we need to configure the blame collector. I'll look into that

@HaoK
Copy link
Member Author

HaoK commented Jul 10, 2020

Right, I just kicked this off as the initial PR starting point

@HaoK
Copy link
Member Author

HaoK commented Jul 10, 2020

@HaoK HaoK changed the title [Helix] See if new vstest dump support works on linux [Helix] Try out the new dotnet test blame functionality Jul 30, 2020
HaoK and others added 21 commits August 6, 2020 17:53
…729.3 (#24456)

Microsoft.Net.Compilers.Toolset
 From Version 3.8.0-1.20367.11 -> To Version 3.8.0-2.20379.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Wait for component to mount before checking for output
* Use Exists to check for element with timeout
* Update ComponentRenderingTest.cs
* Add display environment

* Print out env variables as part of helix runs

* Update TestRunner.cs

* Remove Debian 8 from helix matrix

* Remove Debian 8 skip

* Remove debian 8 skip

* Remove debian 8

* Remove debian 8 skip

* Remove Debian 8 skip

* Remove debian 8

* Update Program.cs

* Update TestRunner.cs

* Update TestRunner.cs
…iles. (#24445)

The output of the declaration file for Razor components are unaffected by all inputs other than the input .razor file.
Consequently we can avoid regenerating these files if the output is newer than the input. This is the same heuristic we apply to Blazor WebAsssembly's
compression artifacts.

This PR combines these two improvements for a ~90ms (10%) improvement in the inner loop.

```
       17 ms  GenerateBlazorWebAssemblyBootJson          1 calls
       22 ms  Copy                                       8 calls
       39 ms  ProcessFrameworkReferences                 1 calls
       40 ms  RazorTagHelper                             1 calls
       51 ms  ResolveAssemblyReference                   1 calls
       70 ms  GetFileHash                                1 calls
       80 ms  RazorGenerate                              2 calls
      111 ms  Csc                                        2 calls

      Time Elapsed 00:00:00.95
```

```
       17 ms  GenerateBlazorWebAssemblyBootJson          1 calls
       21 ms  Copy                                       8 calls
       37 ms  ProcessFrameworkReferences                 1 calls
       51 ms  ResolveAssemblyReference                   1 calls
       70 ms  Csc                                        1 calls
       72 ms  GetFileHash                                1 calls
       79 ms  RazorGenerate                              2 calls

Time Elapsed 00:00:00.86
```

In after: Csc calls reduced to one, RazorTagHelper call removed.
…724.1 (#24482)

Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.20364.3 -> To Version 5.0.0-beta.20374.1
- downgrade of the Arcade SDK should be fine

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Put back InternalCalls

* Removing .NET profiling calls

* Remove JS side profiling
* Update documentation on darc

* Apply suggestions from code review

Co-authored-by: Doug Bunting <[email protected]>

* Update code blocks in referenced assemblies

Co-authored-by: Doug Bunting <[email protected]>
danroth27 and others added 7 commits August 6, 2020 17:54
- just a bit confusing to leave these around
- the files haven't been used since @pakrym removed the resources in 56c064b
- now matches timeout in quarantined-pr.yml which uses the same queues
- internal PRs may otherwise time out
- Annotated UseMiddleware and UseStartup to preserve constructors and public methods.
- Annotated UseHub and MapHub preserve constructors and public methods.
- Added a test to verify UseStartup and UseMiddleware works
- The linker.xml preserves constructors all of the types that are registered in DI. This should be removed once we get the linker friendly DI changes.
@HaoK
Copy link
Member Author

HaoK commented Aug 7, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@HaoK
Copy link
Member Author

HaoK commented Aug 7, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@HaoK
Copy link
Member Author

HaoK commented Aug 19, 2020

Replaced by #25010

@HaoK HaoK closed this Aug 19, 2020
@dougbu dougbu deleted the helix/dmp branch August 21, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants